Scheduler - Fix unstable ContextMenu demo test#32368
Open
Tucchhaa wants to merge 19 commits intoDevExpress:26_1from
Open
Scheduler - Fix unstable ContextMenu demo test#32368Tucchhaa wants to merge 19 commits intoDevExpress:26_1from
Tucchhaa wants to merge 19 commits intoDevExpress:26_1from
Conversation
Signed-off-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes instability in the Scheduler “ContextMenu” demo visual test by adjusting how context-menu behavior is wired in the Scheduler workspace and by refactoring demo implementations across frameworks so context menus are configured more deterministically.
Changes:
- Updated Scheduler workspace cell context-menu event binding to attach handlers on specific tables instead of the workspace root.
- Added a Jest regression test to ensure
onAppointmentContextMenufires only once. - Refactored ContextMenu demos (Angular/Vue/React/jQuery) to use separate context-menu instances per target and re-enabled the demo in the visual-test matrix.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Changes where cell context-menu events are bound (date table vs all-day table). |
| packages/devextreme/js/__internal/scheduler/tests/scheduler.test.ts | Adds regression coverage for duplicate onAppointmentContextMenu calls. |
| apps/demos/utils/visual-tests/matrix-test-helper.ts | Removes “ContextMenu” from the visual-test skip list for multiple frameworks. |
| apps/demos/Demos/Scheduler/ContextMenu/jQuery/index.js | Splits into two ContextMenu instances (appointment vs cell) and updates items dynamically. |
| apps/demos/Demos/Scheduler/ContextMenu/jQuery/index.html | Adds separate context-menu host elements and links demo CSS. |
| apps/demos/Demos/Scheduler/ContextMenu/jQuery/styles.css | Removes menu-specific CSS rules (keeps badge styling). |
| apps/demos/Demos/Scheduler/ContextMenu/Vue/App.vue | Splits into two ContextMenu components and item sources; updates grouping toggles. |
| apps/demos/Demos/Scheduler/ContextMenu/Vue/ItemTemplate.vue | Wraps item template content to stabilize rendering/layout. |
| apps/demos/Demos/Scheduler/ContextMenu/React/App.tsx | Splits into two ContextMenu components and item sources; uses e.component instead of refs. |
| apps/demos/Demos/Scheduler/ContextMenu/React/itemTemplate.tsx | Renames template component to a generic ItemTemplate. |
| apps/demos/Demos/Scheduler/ContextMenu/React/index.html | Links demo CSS. |
| apps/demos/Demos/Scheduler/ContextMenu/React/styles.css | Removes menu-specific CSS rules (keeps badge styling). |
| apps/demos/Demos/Scheduler/ContextMenu/ReactJs/App.js | Same split-context-menu refactor for JS React demo. |
| apps/demos/Demos/Scheduler/ContextMenu/ReactJs/itemTemplate.js | Renames template component to ItemTemplate. |
| apps/demos/Demos/Scheduler/ContextMenu/ReactJs/index.html | Links demo CSS. |
| apps/demos/Demos/Scheduler/ContextMenu/ReactJs/styles.css | Removes menu-specific CSS rules (keeps badge styling). |
| apps/demos/Demos/Scheduler/ContextMenu/Angular/app/app.component.ts | Splits appointment/cell item lists; refactors menu building helpers. |
| apps/demos/Demos/Scheduler/ContextMenu/Angular/app/app.component.html | Adds two context-menu components (appointment vs cell) with shared template. |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Scheduler/ContextMenu/Angular/app/app.component.ts
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Scheduler/ContextMenu/Angular/app/app.component.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.