Scheduler — Replace underscore-prefixed: Long tail (popup, helpers, header, utils)#33009
Open
aleksei-semikozov wants to merge 2 commits intoDevExpress:26_1from
Open
Scheduler — Replace underscore-prefixed: Long tail (popup, helpers, header, utils)#33009aleksei-semikozov wants to merge 2 commits intoDevExpress:26_1from
aleksei-semikozov wants to merge 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the Scheduler internal refactor to eliminate underscore-prefixed members by renaming them to non-underscore equivalents and (where applicable) marking them private, while updating internal call sites and a legacy scheduler test accordingly.
Changes:
- Updated legacy Scheduler appointment popup test to use
tryLockSaveChanges()instead of_tryLockSaveChanges(). - Refactored multiple Scheduler internal modules (appointment popup, compact helper, header/calendar, table creator, appointment data source) to rename underscore-prefixed helpers/fields and adjust call sites.
- Tightened encapsulation in several places by switching renamed members to
private.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/legacyAppointmentPopup.tests.js | Updates the legacy test to match the renamed appointment popup lock method. |
| packages/devextreme/js/__internal/scheduler/view_model/m_appointment_data_source.ts | Renames internal store-key/helper initialization methods and updates internal usage. |
| packages/devextreme/js/__internal/scheduler/m_table_creator.ts | Renames grouped-row creation helpers and marks them private, updating internal callers. |
| packages/devextreme/js/__internal/scheduler/m_compact_appointments_helper.ts | Renames internal template/button/tooltip helper methods and marks them private. |
| packages/devextreme/js/__internal/scheduler/header/m_header.ts | Renames underscore-prefixed header fields to private members and updates references. |
| packages/devextreme/js/__internal/scheduler/header/m_calendar.ts | Renames underscore-prefixed overlay/calendar fields to private members and updates references. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/m_popup.ts | Renames underscore-prefixed popup helpers/handlers to private methods and updates internal references. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/m_legacy_popup.ts | Same refactor as the non-legacy popup: renames underscore-prefixed internals and updates internal usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.