devextreme-aspnet-data: use from /apps/demos/, remove from /packages/devextreme/, arrange vendor files (with bootstrap)#33987
Open
mpreyskurantov wants to merge 1 commit into
Conversation
…l copy, like bootstrap)
3827c8e to
07b2100
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes how vendor assets are sourced and copied into DevExtreme build artifacts by moving devextreme-aspnet-data sourcing to apps/demos/ and integrating Bootstrap into the vendor-copy pipeline (instead of a one-off copy in build-all.ts).
Changes:
- Remove
devextreme-aspnet-datafrompackages/devextremedependencies (and lockfile), and sourcedx.aspnet.data.jsfromapps/demos/node_modules. - Add Bootstrap JS/CSS to
packages/devextremevendor-copy targets, sourcing frompackages/devextreme-themebuilder/node_modules. - Add an Nx target in
packages/workflowsto copydx.aspnet.data.jsinto root artifacts; remove the bootstrap copy step fromtools/scripts/build-all.ts.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Removes the direct Bootstrap copying step, relying on the vendor-copy pipeline instead. |
| pnpm-lock.yaml | Drops devextreme-aspnet-data from the packages/devextreme importer. |
| packages/workflows/project.json | Adds a target to copy dx.aspnet.data.js from apps/demos into root artifacts. |
| packages/devextreme/project.json | Updates vendor-copy targets to include Bootstrap assets and to source dx.aspnet.data.js from apps/demos. |
| packages/devextreme/package.json | Removes devextreme-aspnet-data dependency. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (2)
packages/devextreme/project.json:1146
- This target now copies vendor files from other workspace projects' node_modules (apps/demos and devextreme-themebuilder), but the Nx inputs only include this package.json and the lockfile. Adding the referenced projects' package.json files helps Nx correctly invalidate the cache when those dependencies/peer ranges change.
"inputs": [
"{projectRoot}/package.json",
"{workspaceRoot}/pnpm-lock.yaml"
],
packages/devextreme/project.json:1185
- Same as for copy:vendor:js: since this target reads bootstrap CSS from devextreme-themebuilder's node_modules, include that project's package.json (and apps/demos for aspnet-data parity) in the inputs so Nx cache invalidation reflects those upstream dependency changes.
"inputs": [
"{projectRoot}/package.json",
"{workspaceRoot}/pnpm-lock.yaml"
],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Comments suppressed due to low confidence (2)
packages/devextreme/project.json:1146
packages/devextreme/project.json:1185