Skip to content

devextreme-aspnet-data: use from /apps/demos/, remove from /packages/devextreme/, arrange vendor files (with bootstrap)#33987

Open
mpreyskurantov wants to merge 1 commit into
DevExpress:26_1from
mpreyskurantov:26_1-dxt-aspnet-data-dep
Open

devextreme-aspnet-data: use from /apps/demos/, remove from /packages/devextreme/, arrange vendor files (with bootstrap)#33987
mpreyskurantov wants to merge 1 commit into
DevExpress:26_1from
mpreyskurantov:26_1-dxt-aspnet-data-dep

Conversation

@mpreyskurantov

@mpreyskurantov mpreyskurantov commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

TODO:

Comments suppressed due to low confidence (2)

packages/devextreme/project.json:1146

  • This target now copies vendor files from other workspace projects' node_modules (apps/demos and devextreme-themebuilder), but the Nx inputs only include this package.json and the lockfile. Adding the referenced projects' package.json files helps Nx correctly invalidate the cache when those dependencies/peer ranges change.
      "inputs": [
        "{projectRoot}/package.json",
        "{workspaceRoot}/pnpm-lock.yaml"
      ],

packages/devextreme/project.json:1185

  • Same as for copy:vendor:js: since this target reads bootstrap CSS from devextreme-themebuilder's node_modules, include that project's package.json (and apps/demos for aspnet-data parity) in the inputs so Nx cache invalidation reflects those upstream dependency changes.
      "inputs": [
        "{projectRoot}/package.json",
        "{workspaceRoot}/pnpm-lock.yaml"
      ],

@mpreyskurantov mpreyskurantov self-assigned this Jun 12, 2026
Copilot AI review requested due to automatic review settings June 12, 2026 20:26
@mpreyskurantov mpreyskurantov force-pushed the 26_1-dxt-aspnet-data-dep branch from 3827c8e to 07b2100 Compare June 12, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes how vendor assets are sourced and copied into DevExtreme build artifacts by moving devextreme-aspnet-data sourcing to apps/demos/ and integrating Bootstrap into the vendor-copy pipeline (instead of a one-off copy in build-all.ts).

Changes:

  • Remove devextreme-aspnet-data from packages/devextreme dependencies (and lockfile), and source dx.aspnet.data.js from apps/demos/node_modules.
  • Add Bootstrap JS/CSS to packages/devextreme vendor-copy targets, sourcing from packages/devextreme-themebuilder/node_modules.
  • Add an Nx target in packages/workflows to copy dx.aspnet.data.js into root artifacts; remove the bootstrap copy step from tools/scripts/build-all.ts.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/scripts/build-all.ts Removes the direct Bootstrap copying step, relying on the vendor-copy pipeline instead.
pnpm-lock.yaml Drops devextreme-aspnet-data from the packages/devextreme importer.
packages/workflows/project.json Adds a target to copy dx.aspnet.data.js from apps/demos into root artifacts.
packages/devextreme/project.json Updates vendor-copy targets to include Bootstrap assets and to source dx.aspnet.data.js from apps/demos.
packages/devextreme/package.json Removes devextreme-aspnet-data dependency.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (2)

packages/devextreme/project.json:1146

  • This target now copies vendor files from other workspace projects' node_modules (apps/demos and devextreme-themebuilder), but the Nx inputs only include this package.json and the lockfile. Adding the referenced projects' package.json files helps Nx correctly invalidate the cache when those dependencies/peer ranges change.
      "inputs": [
        "{projectRoot}/package.json",
        "{workspaceRoot}/pnpm-lock.yaml"
      ],

packages/devextreme/project.json:1185

  • Same as for copy:vendor:js: since this target reads bootstrap CSS from devextreme-themebuilder's node_modules, include that project's package.json (and apps/demos for aspnet-data parity) in the inputs so Nx cache invalidation reflects those upstream dependency changes.
      "inputs": [
        "{projectRoot}/package.json",
        "{workspaceRoot}/pnpm-lock.yaml"
      ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants