PivotGrid: open header filter popup by hotkey#33994
Open
sjbur wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds keyboard support for opening PivotGrid field header filters via a hotkey, and adjusts focus/tab behavior to match the new interaction model.
Changes:
- Added
Alt+ArrowDownhandling on focused PivotGrid/FieldChooser fields to open the header filter popup. - Removed the header filter indicator from the tab order to make field-to-field tabbing consistent (one
Tabper field). - Updated TestCafe KBN tests to reflect the new tab order and validate the new hotkey behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts | Adds Alt+ArrowDown shortcut and removes header filter indicator tabindex during column-state rendering |
| e2e/testcafe-devextreme/tests/common/pivotGrid/kbn/fields.ts | Updates keyboard-navigation expectations and adds coverage for opening header filter via Alt+Down |
Comment on lines
+130
to
+138
| protected _applyColumnState(options) { | ||
| const $element = super._applyColumnState(options); | ||
|
|
||
| if (options.name === 'headerFilter' && $element) { | ||
| $element.removeAttr('tabindex'); | ||
| } | ||
|
|
||
| return $element; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Not sure whether we should do this. Suggestions?
Tucchhaa
reviewed
Jun 16, 2026
| const isAltArrowDown = e.type === 'keydown' && e.altKey && e.key === 'ArrowDown'; | ||
|
|
||
| if (isAltArrowDown) { | ||
| const mainGroupField = getMainGroupField(this._dataSource, field); |
Contributor
There was a problem hiding this comment.
why we need mainGroupField? Why not just use field?
Tucchhaa
reviewed
Jun 16, 2026
|
|
||
| const isAltArrowDown = e.type === 'keydown' && e.altKey && e.key === 'ArrowDown'; | ||
|
|
||
| if (isAltArrowDown) { |
Contributor
There was a problem hiding this comment.
Now we have 2 places for opening header filter:
- here
- the old place: https://github.com/DevExpress/DevExtreme/pull/33994/changes#diff-12a89dcfa5ebbc8ea7357eaf5c97ea7d1eea821081fd156023cd736aa14d4a72R401
I suggest to unify them, remove the old logic and add to this condition a check for header filter icon click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.