Add SBOM pipeline#1154
Open
mpreyskurantov wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an SBOM generation/validation pipeline to the repo by introducing a dedicated tools/make-sbom pnpm project (using @devexpress/sbom-toolkit) and wiring SBOM build + validation into GitHub Actions (both a standalone SBOM workflow and the publish workflow).
Changes:
- Add
tools/make-sbompnpm project (lockfile, registry config, SBOM build script) for generating SBOMs for the packed CLI/schematics artifacts. - Introduce a new
.github/workflows/sbom.ymlworkflow to build, validate, and dry-run publish packages on thesbom-devbranch. - Extend
.github/workflows/publish.ymlto also build/upload/validate SBOMs during publish runs, and ignore generated.tgz/distoutputs in.gitignore.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/make-sbom/pnpm-workspace.yaml | Adds pnpm workspace/tooling config for the SBOM tool project. |
| tools/make-sbom/pnpm-lock.yaml | Locks SBOM tool dependency graph for reproducible installs. |
| tools/make-sbom/package.json | Defines the SBOM tool project and SBOM generation script. |
| tools/make-sbom/.npmrc | Points @devexpress scope to GitHub Packages for SBOM toolkit installs. |
| .gitignore | Ignores generated package tarballs and SBOM output directory. |
| .github/workflows/sbom.yml | New workflow to build packages, generate SBOMs, validate them, and dry-run publish. |
| .github/workflows/publish.yml | Adds SBOM build/upload/validation to the publish workflow and updates some actions versions. |
Files not reviewed (1)
- tools/make-sbom/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:35
- This workflow installs dependencies from both
pnpm-lock.yamlandtools/make-sbom/pnpm-lock.yaml, but the pnpm cache key will only consider the default lockfile unlesscache-dependency-pathis set. Include the SBOM tool lockfile to avoid cache misses.
- name: Use Node.js
uses: actions/setup-node@v6
with:
node-version-file: '.node-version'
cache: 'pnpm'
registry-url: 'https://registry.npmjs.org'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.