⚡ Bolt: Optimize TripletDataGenerator sampling#17
⚡ Bolt: Optimize TripletDataGenerator sampling#17google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Precompute `label_to_paths` map for O(1) positive sampling - Implement rejection sampling for O(1) negative sampling - Reduces batch generation time from ~1.27s to ~0.15s (N=20,000)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
💡 What: Replaced O(N) list comprehensions in the batch generation loop with O(1) dictionary lookups and rejection sampling.
🎯 Why: The previous implementation scanned the entire dataset twice for every sample in a batch, causing massive slowdowns as dataset size increased.
📊 Impact: Reduced batch generation time by ~88% (from 1.27s to 0.15s per batch for 20k images).
🔬 Measurement: Verified with a benchmark script using mocked image loading.
PR created automatically by Jules for task 363534553400923119 started by @Devasy23