Skip to content

chore(gateway): align config_schema.json with config DTOs#1812

Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
masterfrom
chore/config-schema-drift
Open

chore(gateway): align config_schema.json with config DTOs#1812
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
masterfrom
chore/config-schema-drift

Conversation

@irvingoujAtDevolution
Copy link
Copy Markdown
Contributor

The hand-maintained config_schema.json had drifted from the config.rs dto module; this re-syncs it attribute-by-attribute (Rust is the source of truth, no Rust changes). It adds missing surfaces (TlsVerifyStrict, MinRecordingStorageFreeSpace, JobQueueDatabase, TrafficAuditDatabase, AgentTunnel, and __debug__'s ws_keep_alive_interval/kerberos with the Kerberos type tree), fixes the ngrok tunnel discriminator (protoProto, matching #[serde(tag = "Proto")]), and drops the incorrect Listeners root requirement (the field has #[serde(default)]). It also corrects the AI provider keys to the names serde actually emits — Lmstudio/Openai/Openrouter/AzureOpenai — since rename_all = "PascalCase" only capitalizes the first letter of each _-separated segment; note these awkward keys come from the Rust field names (openai, azure_openai, …), so if OpenAi/AzureOpenAi are the intended config keys that should be a separate Rust-side #[serde(rename)] fix.

The hand-maintained config schema had drifted from the dto module. Add missing surfaces (TlsVerifyStrict, MinRecordingStorageFreeSpace, JobQueueDatabase, TrafficAuditDatabase, AgentTunnel, __debug__.ws_keep_alive_interval and kerberos), fix the ngrok tunnel discriminator (proto -> Proto), correct the AI provider keys to match serde PascalCase (Lmstudio/Openai/Openrouter/AzureOpenai), and drop the incorrect Listeners root requirement (the field has serde default).
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-syncs the hand-maintained config_schema.json with the Rust config.rs DTOs so that schema validation and documentation match the config that serde actually parses/serializes (without changing any Rust code).

Changes:

  • Added missing top-level and definition surfaces (e.g., TlsVerifyStrict, MinRecordingStorageFreeSpace, JobQueueDatabase, TrafficAuditDatabase, AgentTunnel, and Kerberos / ws_keep_alive_interval under __debug__).
  • Fixed schema discriminators/keys to match serde output (e.g., ngrok tunnel tag key Proto, AI provider keys like Lmstudio / Openai / Openrouter / AzureOpenai).
  • Dropped the incorrect root requirement for Listeners (since the DTO uses #[serde(default)]).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config_schema.json
Comment thread config_schema.json
Comment thread config_schema.json
Comment thread config_schema.json
Comment thread config_schema.json
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread config_schema.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants