feat(initial): initial now-proto-pdu code from IronRDP #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
approved these changes
Dec 13, 2024
Member
CBenoit
left a comment
CBenoit
left a comment
There was a problem hiding this comment.
LGTM!
The CI is red so you’ll have to do something about that, but feel free to merge when you want!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CBenoit this is the initial commit for
now-proto-pdulibrary (rust), I'll post follow-up PR(s) with xtask, testsuit, net proto revision etc. as a follow-up to make it easier to keep track of changes during repo move. This PR is mostly copy-paste; the crate is buildable; After this code PR is merged,now-proto-pducould be removed fromironrdprepo