Skip to content

Conversation

@AnastaZIuk
Copy link
Member

No description provided.

@AnastaZIuk AnastaZIuk marked this pull request as ready for review February 2, 2026 07:56
Copy link
Member

@devshgraphicsprogramming devshgraphicsprogramming Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this function, one can just truncate a wider matrix into more narrow to get any submatrix really

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@devshgraphicsprogramming
Copy link
Member

Can you remove the following:

setTranslation should move to fast_affine.hlsl because the encoding of a translation in the last column of a Nx(N+1) matrix is really an affine thing

they have requivalents here:
https://github.com/Devsh-Graphics-Programming/Nabla/blob/47bfd0478771eaab2ca849d0fcb5d5983ace47ff/include/nbl/builtin/hlsl/math/linalg/matrix_utils.hlsl
and in the quaternions for the angle-axis thing

also linalg/matrix_utils.hlsl should have a better name like linalg/basic.hlsl or core to avoid confusion with the other matrix_utils (the folder higher up)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its all in matrix_utils the runtime traits

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a static_cast specialization for this now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a similar static_cast_helper specialization for vectors, as the one for the matrix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid, we have the expansion functions which take an argument asking what an unitialized element in the diagonal should be

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid, we have the expansion functions which take an argument asking what an unitialized element in the diagonal should be

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Copy link
Member

@devshgraphicsprogramming devshgraphicsprogramming Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is same as the fast_affine promoted_mul function which should be used instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicates with transform.hlsl lhLookAt and rhLookAt`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be same place as setRotation so probably also fast_affine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants