Added C Language#193
Conversation
|
@Akshit-MMQH is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Akshit-MMQH deployment has failed, please check your code well |
There was a problem hiding this comment.
Pull Request Overview
Adds C language support to the app by introducing a C logo component and extending the language constants. Also updates Firebase SDK version.
- Adds C language entry to language constants (name, logo, default, hello world).
- Introduces CLogo SVG component.
- Bumps firebase dependency to ^11.10.0.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/constants/constants.js | Registers C language with logo component and Hello World snippet. |
| src/components/images/CLogo.js | New SVG component for the C language logo. |
| package.json | Updates firebase to ^11.10.0. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| y="0px" | ||
| width={width} | ||
| height={height} | ||
| viewBox="0 0 48 48" |
There was a problem hiding this comment.
The SVG lacks an accessible name or an explicit indication that it is decorative. Either add role="img" with aria-label/title (e.g., aria-label="C programming language logo") or, if purely decorative, mark it as aria-hidden="true" to improve screen reader experience.
| viewBox="0 0 48 48" | |
| viewBox="0 0 48 48" | |
| role="img" | |
| aria-label="C programming language logo" |
| <linearGradient | ||
| id="Ey3AfYdg0JtJGx7I73Eu7a_TpULddJc4gTh_gr1" | ||
| x1="5" | ||
| x2="43" | ||
| y1="24" | ||
| y2="24" | ||
| gradientUnits="userSpaceOnUse" | ||
| > | ||
| <stop offset=".002" stopColor="#427fdb"></stop> | ||
| <stop offset=".397" stopColor="#2668cb"></stop> | ||
| <stop offset=".763" stopColor="#1358bf"></stop> | ||
| <stop offset="1" stopColor="#0c52bb"></stop> | ||
| </linearGradient> | ||
| <path | ||
| fill="url(#Ey3AfYdg0JtJGx7I73Eu7a_TpULddJc4gTh_gr1)" | ||
| fillRule="evenodd" | ||
| d="M22.903,3.286c0.679-0.381,1.515-0.381,2.193,0 c3.355,1.883,13.451,7.551,16.807,9.434C42.582,13.1,43,13.804,43,14.566c0,3.766,0,15.101,0,18.867 c0,0.762-0.418,1.466-1.097,1.847c-3.355,1.883-13.451,7.551-16.807,9.434c-0.679,0.381-1.515,0.381-2.193,0 c-3.355-1.883-13.451-7.551-16.807-9.434C5.418,34.899,5,34.196,5,33.434c0-3.766,0-15.101,0-18.867 c0-0.762,0.418-1.466,1.097-1.847C9.451,10.837,19.549,5.169,22.903,3.286z" | ||
| clipRule="evenodd" | ||
| ></path> |
There was a problem hiding this comment.
The hard-coded SVG IDs (e.g., Ey3AfY...gr1) can collide if multiple CLogo instances render on the same page, breaking gradient references. Use React's useId to generate unique IDs per instance and reference them in the url(#...) fills to avoid DOM ID collisions.
| LOGO: <CLogo />, | ||
| HELLO_WORLD: `#include <stdio.h> | ||
| int main() { | ||
| printf("Hello World"); |
There was a problem hiding this comment.
Consider adding a newline to ensure the output flushes consistently across environments: printf("Hello World\n");.
| printf("Hello World"); | |
| printf("Hello World\n"); |
| }`, | ||
| }, | ||
| { | ||
| ID: LANGUAGE_ID_FOR_C, // Add this object for C |
There was a problem hiding this comment.
[nitpick] Avoid inline comments that restate obvious code intent; they add noise. Recommend removing the trailing comment.
| ID: LANGUAGE_ID_FOR_C, // Add this object for C | |
| ID: LANGUAGE_ID_FOR_C, |
|
@DhanushNehru now check!! |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@DhanushNehru please review |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }`, | ||
| }, | ||
| { | ||
| ID: LANGUAGE_ID_FOR_C, // Add this object for C |
There was a problem hiding this comment.
The constant LANGUAGE_ID_FOR_C is referenced but not defined. This will cause a ReferenceError at runtime.
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Remove unnecessary blank lines at the end of the file to maintain consistent code formatting.
|
Please resolve the code issues and CI/CD pipeline issues @Akshit-MMQH |
[#191]
Checklist before requesting a review
mainbranch