Skip to content

Added C Language#193

Closed
Akshit-MMQH wants to merge 6 commits intoDhanushNehru:mainfrom
Akshit-MMQH:main
Closed

Added C Language#193
Akshit-MMQH wants to merge 6 commits intoDhanushNehru:mainfrom
Akshit-MMQH:main

Conversation

@Akshit-MMQH
Copy link
Copy Markdown

[#191]

Checklist before requesting a review

  • [y] I have pull latest changes from main branch
  • [ y] I have tested the changes locally
  • [ y] I assure there is no similar/duplicate pull request regarding same issue

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 3, 2025

@Akshit-MMQH is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
custom-code-editor Error Error Oct 8, 2025 2:39pm

@DhanushNehru
Copy link
Copy Markdown
Owner

@Akshit-MMQH deployment has failed, please check your code well

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds C language support to the app by introducing a C logo component and extending the language constants. Also updates Firebase SDK version.

  • Adds C language entry to language constants (name, logo, default, hello world).
  • Introduces CLogo SVG component.
  • Bumps firebase dependency to ^11.10.0.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/constants/constants.js Registers C language with logo component and Hello World snippet.
src/components/images/CLogo.js New SVG component for the C language logo.
package.json Updates firebase to ^11.10.0.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

y="0px"
width={width}
height={height}
viewBox="0 0 48 48"
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG lacks an accessible name or an explicit indication that it is decorative. Either add role="img" with aria-label/title (e.g., aria-label="C programming language logo") or, if purely decorative, mark it as aria-hidden="true" to improve screen reader experience.

Suggested change
viewBox="0 0 48 48"
viewBox="0 0 48 48"
role="img"
aria-label="C programming language logo"

Copilot uses AI. Check for mistakes.
Comment on lines +11 to +29
<linearGradient
id="Ey3AfYdg0JtJGx7I73Eu7a_TpULddJc4gTh_gr1"
x1="5"
x2="43"
y1="24"
y2="24"
gradientUnits="userSpaceOnUse"
>
<stop offset=".002" stopColor="#427fdb"></stop>
<stop offset=".397" stopColor="#2668cb"></stop>
<stop offset=".763" stopColor="#1358bf"></stop>
<stop offset="1" stopColor="#0c52bb"></stop>
</linearGradient>
<path
fill="url(#Ey3AfYdg0JtJGx7I73Eu7a_TpULddJc4gTh_gr1)"
fillRule="evenodd"
d="M22.903,3.286c0.679-0.381,1.515-0.381,2.193,0 c3.355,1.883,13.451,7.551,16.807,9.434C42.582,13.1,43,13.804,43,14.566c0,3.766,0,15.101,0,18.867 c0,0.762-0.418,1.466-1.097,1.847c-3.355,1.883-13.451,7.551-16.807,9.434c-0.679,0.381-1.515,0.381-2.193,0 c-3.355-1.883-13.451-7.551-16.807-9.434C5.418,34.899,5,34.196,5,33.434c0-3.766,0-15.101,0-18.867 c0-0.762,0.418-1.466,1.097-1.847C9.451,10.837,19.549,5.169,22.903,3.286z"
clipRule="evenodd"
></path>
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hard-coded SVG IDs (e.g., Ey3AfY...gr1) can collide if multiple CLogo instances render on the same page, breaking gradient references. Use React's useId to generate unique IDs per instance and reference them in the url(#...) fills to avoid DOM ID collisions.

Copilot uses AI. Check for mistakes.
LOGO: <CLogo />,
HELLO_WORLD: `#include <stdio.h>
int main() {
printf("Hello World");
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a newline to ensure the output flushes consistently across environments: printf("Hello World\n");.

Suggested change
printf("Hello World");
printf("Hello World\n");

Copilot uses AI. Check for mistakes.
}`,
},
{
ID: LANGUAGE_ID_FOR_C, // Add this object for C
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Avoid inline comments that restate obvious code intent; they add noise. Recommend removing the trailing comment.

Suggested change
ID: LANGUAGE_ID_FOR_C, // Add this object for C
ID: LANGUAGE_ID_FOR_C,

Copilot uses AI. Check for mistakes.
@Akshit-MMQH
Copy link
Copy Markdown
Author

@DhanushNehru now check!!

@DhanushNehru DhanushNehru requested a review from Copilot October 5, 2025 03:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/components/images/CLogo.js
Comment thread src/constants/constants.js
@Akshit-MMQH
Copy link
Copy Markdown
Author

@DhanushNehru please review

@DhanushNehru DhanushNehru requested a review from Copilot October 8, 2025 14:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}`,
},
{
ID: LANGUAGE_ID_FOR_C, // Add this object for C
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constant LANGUAGE_ID_FOR_C is referenced but not defined. This will cause a ReferenceError at runtime.

Copilot uses AI. Check for mistakes.
Comment on lines +70 to +72



Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove unnecessary blank lines at the end of the file to maintain consistent code formatting.

Suggested change

Copilot uses AI. Check for mistakes.
@DhanushNehru
Copy link
Copy Markdown
Owner

Please resolve the code issues and CI/CD pipeline issues @Akshit-MMQH

@Akshit-MMQH Akshit-MMQH closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants