Changing icon imports. Also, standardised names.#156
Merged
Conversation
akademy
force-pushed
the
jmbw/fix-icon-imports
branch
from
f22ad6f to
eca156d
Compare
VictoriaBeilsten-Edmands
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for importing icons within tests in an external app which users sci-react-ui.
Basically, the conversion of the SVG icons is not correct ESM, this change makes sure they are imported correctly. (details of the problem here mui/material-ui#35233 )
I also standardized the icon names to "Icon".