Skip to content

Introduce Lucide based Icon component and updates#209

Open
zoharma wants to merge 4 commits into
mainfrom
zma/ds-theme-lucide-icons
Open

Introduce Lucide based Icon component and updates#209
zoharma wants to merge 4 commits into
mainfrom
zma/ds-theme-lucide-icons

Conversation

@zoharma

@zoharma zoharma commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • Added Lucide Icons as basis for all icons
  • Updated components, stories with relevancy to icons
  • Updated MuiWrapped
  • Updated and removed dependency for react-icons
  • Updated and removed dependency for @mui/icons-material
  • Removed react-icons package

Note: We can also safely remove @mui/icons-material package but not sure of others may use it

@akademy akademy self-requested a review June 9, 2026 12:06
@zoharma zoharma force-pushed the zma/ds-theme-lucide-icons branch from 01666b0 to ab960fa Compare June 9, 2026 12:39
@zoharma zoharma marked this pull request as draft June 9, 2026 12:58
@zoharma zoharma marked this pull request as ready for review June 9, 2026 14:20
@zoharma zoharma force-pushed the zma/ds-theme-lucide-icons branch from 492ae7a to 5c56b01 Compare June 9, 2026 14:28
@zoharma zoharma force-pushed the zma/ds-theme-lucide-icons branch from 4a43d76 to 88f577a Compare June 15, 2026 09:55
zoharma added 4 commits June 15, 2026 10:56
Added Lucide Icons as basis for most places
Updated stories with relevancy to icons (alert)
Updated Alert in MuiWrapped
We can also Remove `@mui/icons-material` but not sure of others may use it
+ Removed reference to unused icon
@zoharma zoharma force-pushed the zma/ds-theme-lucide-icons branch from 88f577a to 0190d4c Compare June 15, 2026 09:59
@akademy

akademy commented Jun 15, 2026

Copy link
Copy Markdown
Member

I was expecting this to just replace the icons line by line. Can you explain what the additional complexity is trying to achieve? (in particular, all the files in DataDisplay/Icons)

@zoharma zoharma removed the v0.6.0 label Jun 15, 2026
@zoharma

zoharma commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

I was expecting this to just replace the icons line by line. Can you explain what the additional complexity is trying to achieve? (in particular, all the files in DataDisplay/Icons)

As far as I understand, it's better to run Lucide Icons through MuiSvg as then props can be passed through to it. Also, the sizes (expanded list) and weight (Lucide specific) are not directly refelcted, so this covers for that.

Key icons will be in the theme, but if an app wants to use other icons they can import it from Lucide, and then use LucideIcon as the component with the right size as needed. We need to document that potentially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants