Implement sidebar nav with simple nav item#214
Closed
douglaswinter wants to merge 1 commit into
Closed
Conversation
douglaswinter
force-pushed
the
dw/sidebar_nav
branch
from
67a7aec to
6447121
Compare
Contributor
|
Nice one. Looks good. Do we need to create overrides or updates for the selected states for the "ListItemButton" component? |
Member
|
Hi. Could you make this a branch, rather than a fork? Just makes it easier to check out. Do you have rights to make branches? |
Author
No, the selected style is defined, there's just something missing here which sets the state, will add next. |
Author
Sure |
Author
|
Closing in favour of a PR from local branch (#221) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #210 apart from the expandable nav item.