Support for loading config object from "<(/usr/bin/envsubst < template)"#187
Open
LucidOne wants to merge 3 commits intoDiffSK:masterfrom
Open
Support for loading config object from "<(/usr/bin/envsubst < template)"#187LucidOne wants to merge 3 commits intoDiffSK:masterfrom
LucidOne wants to merge 3 commits intoDiffSK:masterfrom
Conversation
Jamim
suggested changes
Jul 6, 2019
d6e42cb to
6d166d9
Compare
LucidOne
added a commit
to LucidOne/configobj
that referenced
this pull request
Jul 6, 2019
6d166d9 to
9d7a288
Compare
Co-Authored-By: Aliaksei Urbanski <mimworkmail@gmail.com>
19db23a to
ae4b6ab
Compare
Author
|
I'm not sure why coverage dropped, but it looks like the tests work. |
Author
|
Is there anything left to get this merged? |
Author
|
Any update on this? |
Author
|
Is it possible to get this merged? I'd like to improve the letsencrypt certbot docker container for doing dns based wildcard cert requests and this is blocking me. |
Author
|
Would it help to rebase this? |
Collaborator
|
Hi, what are the security implications of these changes? How trusted are files read by configobj today? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configobj has an issue being passed a file descriptor (/dev/fd) via process substitution.
os.path.isfile("/dev/fd/{{ anything }}")returnsFalsefor file descriptors whileos.path.exists()returnsTrue.test.py
I'll update the PR with a test when I get a chance
This is needed in cloud environments where you may not want to store passwords on disk in an unencrypted form or have variables passed into a container environment.