v0.42.3: install-statusline defaults to TP-only (drop caveman by default)#44
Merged
Conversation
User reaction: install-statusline put `[CAVEMAN] [TP]` in the status
bar — "why did you add caveman? we don't need it." Fair. The previous
default installed the CHAIN wrapper, which renders a third-party tool's
badge alongside ours. We install OUR badge; deciding that caveman's
badge belongs in your status bar is the same presumption class as the
sessionTitle clobber.
Fix: default is now the TP-only badge (tp-statusline.sh → `[TP deny
27k]`). `--chain` opts into the combined `[CAVEMAN] [TP]` view.
State handling:
- not-configured → TP-only (or chain with --chain)
- configured-chain → switch to TP-only by default (drops the
caveman badge — exactly the user's case);
--chain keeps it
- configured-tp-only → no-op (or upgrade to chain with --chain)
- configured-caveman-only → NOT replaced (it's caveman's, not ours);
--chain adds [TP] alongside, --force replaces
- configured-other / unknown → untouched without --force
decideStatuslineAction now returns the command to write and takes
{force, chain}. New TP_ONLY_COMMAND constant.
Tests: 1355/1355 pass (+6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User: install-statusline put
[CAVEMAN] [TP]in the bar — why add caveman? Fair. The old default installed the chain wrapper (renders a third-party badge too). We install OUR badge; presuming caveman belongs there = the sessionTitle-clobber class.Fix: default = TP-only (
tp-statusline.sh→[TP deny 27k]).--chainopts into[CAVEMAN] [TP].1355/1355 tests.