ENG-1692: Open ModifyNodeModal pre-populated on hotkey node creation#1001
Open
trangdoan982 wants to merge 1 commit intomainfrom
Open
ENG-1692: Open ModifyNodeModal pre-populated on hotkey node creation#1001trangdoan982 wants to merge 1 commit intomainfrom
trangdoan982 wants to merge 1 commit intomainfrom
Conversation
Instead of immediately calling createDiscourseNode after a type is picked in InlineNodeTypePicker, open ModifyNodeModal with the selected text as initialTitle and the chosen type pre-selected — consistent with right-click and tag-click creation flows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/f5f4e01ba347431b89f50b0a4679d3fe
Summary
InlineNodeTypePicker, openModifyNodeModalpre-filled with the selected text and the chosen node type — instead of immediately creating the nodeModifyNodeModalcreateModifyNodeModalSubmitHandlerfromregisterCommands.ts(already exported)Test plan
\) →InlineNodeTypePickerappearsModifyNodeModalopens with title pre-filled to the selected text and the chosen type pre-selected[[NodeTitle]]NodeTagSuggestPopoverunchanged (no regression)🤖 Generated with Claude Code