Skip to content

ENG-1691: Open ModifyNodeModal for convert-into flow with existing node support#1002

Open
trangdoan982 wants to merge 1 commit intomainfrom
eng-1691-enable-open-modifynodemodal-for-convert-into-flow-for-texts
Open

ENG-1691: Open ModifyNodeModal for convert-into flow with existing node support#1002
trangdoan982 wants to merge 1 commit intomainfrom
eng-1691-enable-open-modifynodemodal-for-convert-into-flow-for-texts

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented May 5, 2026

https://www.loom.com/share/7f235985b2d8403c9d4e3164578192f5

Summary

  • Opens ModifyNodeModal pre-filled with shape content when converting a text/image shape via the canvas "Convert to" context menu
  • When the user selects an existing discourse node from the modal's search results, that node is inserted as a new canvas shape directly — no new file is created
  • For image shapes, image content is only embedded in newly created nodes; existing nodes are not modified (but the canvas shape still shows the image as a preview)
  • Adds docs for the convert-to-shape flow in the Obsidian canvas feature page

Test plan

  • Right-click a text shape → Convert to → select a node type → modal opens pre-filled with text
    • Type a new title → Confirm → new discourse node file is created and shape is replaced
    • Search for existing node → select it → Confirm → existing node is inserted as a shape, no new file created
  • Right-click an image shape → Convert to → select a node type → modal opens with empty title
    • Enter a new title → Confirm → new file created with image embedded, shape replaced
    • Select an existing node → Confirm → existing node inserted as shape, no image embedded into the file
  • Cancel the modal → original shape remains unchanged

🤖 Generated with Claude Code

… node selection

When converting a text/image shape via the "Convert to" menu, the
ModifyNodeModal now opens pre-filled with the shape's content. If the user
selects an existing discourse node from the search results, that node is
inserted as a new canvas shape directly instead of creating a new file.
For image shapes, the image is only embedded in newly created nodes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 5, 2026

@supabase
Copy link
Copy Markdown

supabase Bot commented May 5, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant