eng-1344 f10b upload obsidian relations and their schemas by maparent · Pull Request #721 · DiscourseGraphs/discourse-graph

maparent · 2026-01-22T22:03:34Z

This uploads relationship schemas to supabase.

https://www.loom.com/share/ce2382d45c6741838fa6cf6b6f7e3d97

linear · 2026-01-22T22:03:37Z

supabase · 2026-01-22T22:03:40Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

#722) * eng-1344 f10b upload obsidian relations and their schemas * current progress * feature finished * address PR comments * address PR comments * remove local test file * curr progress * revert what is handled in #721 * Use SpaceURI rather than spaceId in frontmatter * address PR comments * address PR comments * cleanup * Update apps/obsidian/src/utils/importNodes.ts Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * normalize on using numbers for dates * correction * apply ctime, mtime to assets * spurious log * Preserve ctime, mtime in processFrontMatter. Also timezone correction * add lastModified in frontMatter * make sure import image works * add recursive folder creation * modify the fetchNodeContent flow; simplify the pathMapping * WIP: shuffle the filePath around * send originalPathDepth * actually send path itself * clarify var name * make sure fileImport works for all possible settings * store relative path when rewrite the wikilink instead of default to fileToLinkText * cleanup logs * nit * AI corrections * Update apps/obsidian/src/utils/importNodes.ts Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * address PR comments --------- Co-authored-by: Marc-Antoine Parent <maparent@acm.org> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration

Devin Review found 2 new potential issues.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 19 additional findings in Devin Review.

devin-ai-integration · 2026-02-22T14:45:07Z

apps/obsidian/src/utils/syncDgNodesToSupabase.ts

🔴 Missing legacy importedFromSpaceUri check in collectDiscourseNodesFromPaths allows imported nodes to sync as local

When checking whether to skip imported files during sync, collectDiscourseNodesFromPaths only checks for importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

The shared collectDiscourseNodesFromVault in apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both keys:

if ( (frontmatter.importedFromRid || frontmatter.importedFromSpaceUri) && includeImported !== true ) { continue; }

But collectDiscourseNodesFromPaths at apps/obsidian/src/utils/syncDgNodesToSupabase.ts:717 only checks the new key:

if (frontmatter.importedFromRid) { continue; }

The migration from importedFromSpaceUri → importedFromRid runs inside initializeSupabaseSync which is fire-and-forget (void) at apps/obsidian/src/index.ts:47. The FileChangeListener starts immediately after and calls syncDiscourseNodeChanges → collectDiscourseNodesFromPaths. If migration hasn't completed yet, or if it fails (the error is caught and only logged at apps/obsidian/src/syncDgNodesToSupabase.ts:916-918), files with the legacy importedFromSpaceUri would pass this check and be incorrectly synced to Supabase as locally-authored nodes.

Impact: Imported nodes could be re-uploaded to Supabase as new local concepts/content, causing duplicate data in the user's space.

(Refers to lines 717-720)

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 21 additional findings in Devin Review.

trangdoan982 · 2026-02-23T17:30:03Z

apps/obsidian/src/utils/conceptConversion.ts

+    ...otherData
+  } = node;
+  /* eslint-disable @typescript-eslint/naming-convention */
+  const literal_content: Record<string, Json> = {


I'm thinking maybe we should have a stronger type system for Concepts.literal_content and Content.metadata. We already use metadata for Wikilink import (we store the full path of the file there). with different types that we upload here (Node, Relation, schemas), it might get messy really soon if we don't enforce the type and still read data from these json columns. It's not blocking for now, we can make this a separate ticket and create the corresponding literal_content type for each Node/Relation Instance-schema separately. or if you prefer to just add the Type in this PR for relation instance and schema that works too

This one I want to address later, it requires thought.

yes non blocking for now

apps/obsidian/src/utils/conceptConversion.ts

apps/obsidian/src/utils/syncDgNodesToSupabase.ts

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 22 additional findings in Devin Review.

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 20 additional findings in Devin Review.

trangdoan982 · 2026-02-23T22:15:24Z

apps/obsidian/src/utils/syncDgNodesToSupabase.ts

@@ -470,29 +490,103 @@ const convertDgToSupabaseConcepts = async ({
  const lastSchemaSync = (


ok so on my local test there's a problem with using this lastSchemaSync to fetch relationType to sync:

all the instances were uploaded but not the relation schemas

i think the reason is that lastSchema sync is for node type. and since the local relation types were modified before we uploaded the node types, this isn't picked up by the system.

this could be the consequence of us shipping the publish nodes before shipping publishing relations in our dev flow. but since Holehouse lab will also use the publish nodes first we should use a different way to get lastSchemaSync separately for node vs relation schema.

here's the screenshot of my local test: no relationType or relationTripletSchema is uploaded:

trangdoan982 · 2026-02-23T22:16:07Z

apps/obsidian/src/utils/syncDgNodesToSupabase.ts

@@ -470,29 +490,103 @@ const convertDgToSupabaseConcepts = async ({
  const lastSchemaSync = (


here's the screenshot of my local test: no relationType or relationTripletSchema is uploaded:

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 21 additional findings in Devin Review.

… roam. Also destructure

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

The FileChangeListener.shouldSyncFile gating function only checks importedFromRid but not the legacy importedFromSpaceUri frontmatter key.

Root Cause and Impact

At apps/obsidian/src/utils/fileChangeListener.ts:101, only importedFromRid is checked:

if (frontmatter?.importedFromRid) {
  return false;
}

But the shared collectDiscourseNodesFromVault at apps/obsidian/src/utils/getDiscourseNodes.ts:32-38 correctly checks both:

(frontmatter.importedFromRid || frontmatter.importedFromSpaceUri)

The FileChangeListener is initialized immediately at apps/obsidian/src/index.ts:56-58, while the migration from importedFromSpaceUri to importedFromRid runs asynchronously in a fire-and-forget initializeSupabaseSync call at line 47. If a user modifies an imported file (still bearing importedFromSpaceUri) before migration completes, shouldSyncFile returns true and the change is queued for sync as if it were a locally-authored node.

Impact: Imported files could be incorrectly identified as needing sync, leading to them being treated as local nodes in the sync pipeline.

View 21 additional findings in Devin Review.

maparent force-pushed the eng-1343-f10a-sync-node-schema-definitions branch from 6bfab2f to 408ef40 Compare January 24, 2026 15:54

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch 2 times, most recently from f966a5b to 7f0a45d Compare January 24, 2026 18:30

maparent force-pushed the eng-1343-f10a-sync-node-schema-definitions branch from 5fdb70d to 0b3d0cb Compare January 25, 2026 15:07

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch 2 times, most recently from 3d49688 to 3b0a73a Compare January 25, 2026 15:21

maparent force-pushed the eng-1343-f10a-sync-node-schema-definitions branch from 3fb53ae to f661f0f Compare January 27, 2026 17:08

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 3b0a73a to 6c48b9f Compare January 27, 2026 17:11

maparent force-pushed the eng-1343-f10a-sync-node-schema-definitions branch from f661f0f to df19c3c Compare January 27, 2026 19:25

Base automatically changed from eng-1343-f10a-sync-node-schema-definitions to main January 27, 2026 19:27

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch 3 times, most recently from ea45b20 to 9e74420 Compare February 1, 2026 21:59

maparent mentioned this pull request Feb 5, 2026

[ENG-1295 & ENG-1350 & ENG-1297] F5 import and refresh published nodes #722

Merged

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 9e74420 to 63c0832 Compare February 5, 2026 15:37

maparent added a commit that referenced this pull request Feb 5, 2026

revert what is handled in #721

a0f90d3

trangdoan982 pushed a commit that referenced this pull request Feb 7, 2026

revert what is handled in #721

3873083

trangdoan982 pushed a commit that referenced this pull request Feb 8, 2026

revert what is handled in #721

428fbf9

maparent added a commit that referenced this pull request Feb 8, 2026

revert what is handled in #721

976c400

trangdoan982 pushed a commit that referenced this pull request Feb 8, 2026

revert what is handled in #721

5469397

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 63c0832 to 982652f Compare February 11, 2026 00:51

maparent marked this pull request as ready for review February 11, 2026 18:52

This comment was marked as resolved.

Sign in to view

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch 2 times, most recently from e82b16b to 376b1a4 Compare February 11, 2026 23:20

This comment was marked as resolved.

Sign in to view

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from d406e78 to 0f8912b Compare February 11, 2026 23:48

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 595e8a2 to 30e40b2 Compare February 22, 2026 14:37

devin-ai-integration bot reviewed Feb 22, 2026

View reviewed changes

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 30e40b2 to bb38514 Compare February 23, 2026 16:30

maparent force-pushed the eng-1461-use-full-rid-instead-of-just-spaceuri-as-marker-of-import branch from 6983308 to 5699c31 Compare February 23, 2026 16:30

This comment was marked as resolved.

Sign in to view

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from bb38514 to 6784bf7 Compare February 23, 2026 17:17

devin-ai-integration bot reviewed Feb 23, 2026

View reviewed changes

trangdoan982 reviewed Feb 23, 2026

View reviewed changes

apps/obsidian/src/utils/conceptConversion.ts Show resolved Hide resolved

trangdoan982 reviewed Feb 23, 2026

View reviewed changes

apps/obsidian/src/utils/syncDgNodesToSupabase.ts Outdated Show resolved Hide resolved

trangdoan982 reviewed Feb 23, 2026

View reviewed changes

apps/obsidian/src/utils/syncDgNodesToSupabase.ts Show resolved Hide resolved

trangdoan982 requested changes Feb 23, 2026

View reviewed changes

Base automatically changed from eng-1461-use-full-rid-instead-of-just-spaceuri-as-marker-of-import to main February 23, 2026 18:59

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from 6784bf7 to 91b4992 Compare February 23, 2026 19:02

devin-ai-integration bot reviewed Feb 23, 2026

View reviewed changes

maparent requested a review from trangdoan982 February 23, 2026 19:48

devin-ai-integration bot reviewed Feb 23, 2026

View reviewed changes

trangdoan982 reviewed Feb 23, 2026

View reviewed changes

trangdoan982 requested changes Feb 23, 2026

View reviewed changes

maparent requested a review from trangdoan982 February 24, 2026 20:24

maparent added 3 commits February 24, 2026 15:25

eng-1344 f10b upload obsidian relations and their schemas

3ee6552

Address review comments

d4f033a

Distinguish sync time of node vs relation schemata

a6f2d9e

maparent force-pushed the eng-1344-upload-relation-and-rel-schema branch from cc52d2f to a6f2d9e Compare February 24, 2026 20:26

devin-ai-integration bot reviewed Feb 24, 2026

View reviewed changes

pointed out by Devin: port processed correction from Obsidian back to…

9202cf1

… roam. Also destructure

devin-ai-integration bot reviewed Feb 25, 2026

View reviewed changes

trangdoan982 approved these changes Feb 25, 2026

View reviewed changes

maparent merged commit 4d43317 into main Feb 25, 2026
10 checks passed

maparent deleted the eng-1344-upload-relation-and-rel-schema branch February 25, 2026 18:26

		@@ -470,29 +490,103 @@ const convertDgToSupabaseConcepts = async ({
		const lastSchemaSync = (

Conversation

maparent commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jan 22, 2026

Uh oh!

supabase bot commented Jan 22, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

devin-ai-integration bot Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

maparent Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

trangdoan982 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 Missing legacy importedFromSpaceUri check in shouldSyncFile allows imported file changes to be queued (apps/obsidian/src/utils/fileChangeListener.ts:101-103)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maparent commented Jan 22, 2026 •

edited

Loading

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)

🐛 Missing legacy `importedFromSpaceUri` check in `shouldSyncFile` allows imported file changes to be queued (`apps/obsidian/src/utils/fileChangeListener.ts:101-103`)