Open
Conversation
- Check if only the relation shape is selected before applying bend changes - When multiple shapes are selected together, perform simple translation - Preserves existing behavior when dragging arrow alone (bend changes allowed) - Aligns with tldraw native arrow behavior for group movements Co-authored-by: Trang Doan <trangdoan982@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
mdroidian
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/49c3b4960dbb4baf8a5e1a7a2a1391e3
Fixes DiscourseRelationShape's
onTranslateto prevent unexpected bend changes when moving multiple selected shapes.Previously, when both ends of a
DiscourseRelationShapewere bound, itsonTranslatemethod would always convert translation into bend changes. This was incorrect when the relation was moved as part of a larger selection of shapes (e.g., nodes and the connecting arrow). The change ensures that bend changes only occur if only the relation shape is selected, allowing for simple translation when moved with other shapes, aligning with tldraw's native arrow behavior.Linear Issue: ENG-1366