Make query builder results dark-mode responsive#785
Draft
mattakamatsu wants to merge 1 commit intomainfrom
Draft
Make query builder results dark-mode responsive#785mattakamatsu wants to merge 1 commit intomainfrom
mattakamatsu wants to merge 1 commit intomainfrom
Conversation
Replace hardcoded light-mode colors (#eeeeee80 inline styles, bg-white, bg-gray-* Tailwind classes) with dark: variant counterparts so the query builder table, kanban, and results views adapt to Roam's dark mode. Also fix the Roam app's Tailwind config to use .bp3-dark as the dark mode class selector, since Roam applies bp3-dark (not .dark) in dark mode. https://claude.ai/code/session_0132ew9iSyEjodJGd9vsWqb5
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded light-mode colors (#eeeeee80 inline styles, bg-white, bg-gray-* Tailwind classes) with dark: variant counterparts so the query builder table, kanban, and results views adapt to Roam's dark mode.
Also fix the Roam app's Tailwind config to use .bp3-dark as the dark mode class selector, since Roam applies bp3-dark (not .dark) in dark mode.
https://claude.ai/code/session_0132ew9iSyEjodJGd9vsWqb5
Test plan
Load in Roam Research with dark mode enabled
Open a query builder result in table view — headers and toolbar backgrounds should use dark colors
Switch to Kanban view — cards, columns, and legend should have dark backgrounds
Toggle back to light mode — verify original appearance is preserved
Check that FuzzySelectInput locked state also renders correctly in dark mode (pre-existing dark: classes now functional)
Log in Roam issue