Skip to content

dual write page group to block props #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sid597 wants to merge 2 commits into from
Closed

dual write page group to block props #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ccc071
dual write page group to block props
sid597 Feb 17, 2026
d1168f9
fix after restack
sid597 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions apps/roam/src/components/settings/PageGroupPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ import createBlock from "roamjs-components/writes/createBlock";
import deleteBlock from "roamjs-components/writes/deleteBlock";
import getAllPageNames from "roamjs-components/queries/getAllPageNames";
import { type PageGroup } from "~/utils/getSuggestiveModeConfigSettings";
import { setGlobalSetting } from "~/components/settings/utils/accessors";

const syncPageGroupsToBlockProps = (groups: PageGroup[]) => {
setGlobalSetting(
["Suggestive mode", "Page groups"],
groups.map((g) => ({ name: g.name, pages: g.pages.map((p) => p.name) })),
);
};

const PageGroupsPanel = ({
uid,
Expand All @@ -31,7 +39,12 @@ const PageGroupsPanel = ({
parentUid: uid,
node: { text: name },
});
setPageGroups([...pageGroups, { uid: newGroupUid, name, pages: [] }]);
const updatedGroups = [
...pageGroups,
{ uid: newGroupUid, name, pages: [] },
];
setPageGroups(updatedGroups);
syncPageGroupsToBlockProps(updatedGroups);
setNewGroupName("");
setGroupKeys((prev) => prev + 1);
} catch (e) {
Expand All @@ -42,7 +55,9 @@ const PageGroupsPanel = ({
const removeGroup = async (groupUid: string) => {
try {
await deleteBlock(groupUid);
setPageGroups(pageGroups.filter((g) => g.uid !== groupUid));
const updatedGroups = pageGroups.filter((g) => g.uid !== groupUid);
setPageGroups(updatedGroups);
syncPageGroupsToBlockProps(updatedGroups);
} catch (e) {
console.error("Error removing group", e);
}
Expand All @@ -58,13 +73,13 @@ const PageGroupsPanel = ({
parentUid: groupUid,
node: { text: page },
});
setPageGroups(
pageGroups.map((g) =>
g.uid === groupUid
? { ...g, pages: [...g.pages, { uid: newPageUid, name: page }] }
: g,
),
const updatedGroups = pageGroups.map((g) =>
g.uid === groupUid
? { ...g, pages: [...g.pages, { uid: newPageUid, name: page }] }
: g,
);
setPageGroups(updatedGroups);
syncPageGroupsToBlockProps(updatedGroups);
setNewPageInputs((prev) => ({
...prev,
[groupUid]: "",
Expand All @@ -81,13 +96,13 @@ const PageGroupsPanel = ({
const removePageFromGroup = async (groupUid: string, pageUid: string) => {
try {
await deleteBlock(pageUid);
setPageGroups(
pageGroups.map((g) =>
g.uid === groupUid
? { ...g, pages: g.pages.filter((p) => p.uid !== pageUid) }
: g,
),
const updatedGroups = pageGroups.map((g) =>
g.uid === groupUid
? { ...g, pages: g.pages.filter((p) => p.uid !== pageUid) }
: g,
);
setPageGroups(updatedGroups);
syncPageGroupsToBlockProps(updatedGroups);
} catch (e) {
console.error("Error removing page from group", e);
}
Expand Down
2 changes: 1 addition & 1 deletion apps/roam/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
DISALLOW_DIAGNOSTICS,
} from "./data/userSettings";
import { initSchema } from "./components/settings/utils/init";

export const DEFAULT_CANVAS_PAGE_FORMAT = "Canvas/*";

export default runExtension(async (onloadArgs) => {
Expand Down Expand Up @@ -155,7 +156,6 @@ export default runExtension(async (onloadArgs) => {
}

await initSchema();

return {
elements: [
style,
Expand Down