Closed
Conversation
- Updated updateMarkdownAssetLinks to handle non-asset wikilinks
- Non-asset wikilinks are now rewritten to point to import/{spaceName}/ directory
- This ensures files created by clicking wikilinks are placed in the correct location
- Resolves relative wikilinks based on original note path before rewriting
Fixes: ENG-1450
Co-authored-by: Trang Doan <trangdoan982@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
trangdoan982
deleted the
cursor/ENG-1450-wikilink-import-pathing-750d
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate all wikilinks in imported notes to relative paths within the
import/{vaultName}/directory.Previously, wikilinks that were not assets were not imported with relative paths. This led to issues where clicking on such a link would create a new file in the root folder of the imported vault, rather than within the designated
import/{vaultName}/structure. This PR ensures that all wikilinks resolve correctly to their intended location within the imported vault, maintaining organization and preventing incorrect file creation.Linear Issue: ENG-1450