Skip to content

Node selection focus #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trangdoan982 wants to merge 3 commits into from
Closed

Node selection focus #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c925bd1
Remove focus conflicts and add enforceFocus={false} to Dialog
cursoragent Feb 19, 2026
4a9a235
Add focus management to move to Confirm button after node selection
cursoragent Feb 19, 2026
8f512d3
Simplify focus management by handling it in setValue callbacks
cursoragent Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/roam/src/components/FuzzySelectInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ const FuzzySelectInput = <T extends Result = Result>({
setQuery(item.text);
setValue(item);
setIsOpen(false);
requestAnimationFrame(() => inputRef.current?.focus());
}
},
[mode, initialUid, setValue, onLockedChange],
Expand Down
13 changes: 11 additions & 2 deletions apps/roam/src/components/ModifyNodeDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ const ModifyNodeDialog = ({
const contentRequestIdRef = useRef(0);
const referencedNodeRequestIdRef = useRef(0);
const [error, setError] = useState("");
const confirmButtonRef = useRef<HTMLButtonElement>(null);

const discourseNodes = useMemo(() => {
const allNodes = getDiscourseNodes();
Expand Down Expand Up @@ -229,11 +230,17 @@ const ModifyNodeDialog = ({

const setValue = useCallback((r: Result) => {
setContent(r);
}, []);
if (r.uid && r.uid !== initialValue.uid) {
confirmButtonRef.current?.focus();
}
}, [initialValue.uid]);

const setReferencedNodeValueCallback = useCallback((r: Result) => {
setReferencedNodeValue(r);
}, []);
if (r.uid && r.uid !== initialReferencedNode?.uid) {
confirmButtonRef.current?.focus();
}
}, [initialReferencedNode?.uid]);

const onCancelClick = useCallback(() => {
onClose();
Expand Down Expand Up @@ -491,6 +498,7 @@ const ModifyNodeDialog = ({
onClose={onClose}
canEscapeKeyClose
autoFocus={false}
enforceFocus={false}
className={"roamjs-canvas-dialog"}
>
<div
Expand Down Expand Up @@ -570,6 +578,7 @@ const ModifyNodeDialog = ({
onClick={() => void onSubmit()}
disabled={loading || !content.text.trim()}
className="flex-shrink-0"
elementRef={confirmButtonRef}
/>
<Button
text="Cancel"
Expand Down