ENG-1217: Port section component in left sidebar#804
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughThe PR migrates left-sidebar settings components to new block-prop driven persistence approaches. Global settings now wire GlobalFlagPanel with setGlobalSetting for page operations (add/move/remove), while personal settings implement PersonalNumberPanel with a new sectionsToBlockProps synchronization layer and setPersonalSetting persistence. Zod schemas are updated to use UID-based identifiers and array-based structures. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mdroidian
left a comment
There was a problem hiding this comment.
The audio in the loom is mostly inaudible. Please review the looms before submitting.
Also, a couple files are not formatted again.
There's a single comment asking to explain why caused the PersonalNumberPanel to break the pattern from the others. I think it would be worth exploring that deeper to see if there are alternative solutions prior to breaking the pattern.
|
|
||
| export const PersonalNumberPanel = (props: NumberWrapperProps) => ( | ||
| <BaseNumberPanel {...props} {...personalAccessors.number} /> | ||
| export const PersonalNumberPanel = ({ setter, ...props }: NumberWrapperProps) => ( |
| uid={globalSection.settings?.folded?.uid || ""} | ||
| parentUid={globalSection.settings?.uid || ""} | ||
| disabled={!globalSection.children?.length} | ||
|
|
| export const PersonalNumberPanel = (props: NumberWrapperProps) => ( | ||
| <BaseNumberPanel {...props} {...personalAccessors.number} /> | ||
| export const PersonalNumberPanel = ({ setter, ...props }: NumberWrapperProps) => ( | ||
| <BaseNumberPanel {...props} setter={setter ?? personalAccessors.number.setter} /> |
There was a problem hiding this comment.
Why is this panel breaking the pattern with setter? What is the reason/need for this?

https://www.loom.com/share/f375f9fab2864d4ab06cd020eeafeaea
Summary by CodeRabbit
Bug Fixes
Improvements