Merged
Conversation
There was a problem hiding this comment.
This pull request establishes a solid foundation for the project's development workflow by adding linting, build scripts, and CI. The changes are generally well-implemented, but there are a few critical issues in the GitHub Actions configuration that will cause the CI to fail. I've provided suggestions to fix the invalid action versions and to simplify the caching logic, aligning it with best practices.
dec9351 to
58c4574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up:
check— runs all check:* scripts in parallel (usingnpm-run-all2)check:types—tsc --noEmitcheck:biome—biome checkfix— runs all fix:* scripts in parallelfix:biome—biome check --writebuild—tscpull_request.yml— Run check, build on PRscheck-semantic-pull-request.yml— Enforce conventional commit PR titles