refactor: deduplicate KMS auth helpers#581
Merged
Conversation
…thority Move shared helper functions (dstack_client, app_attest, pad64, ensure_self_kms_allowed, ensure_kms_allowed) into upgrade_authority.rs and reuse them from onboard_service.rs. Remove the no-op ensure_remote_kms_allowed wrapper.
- Add QEMU user-mode networking note (host at 10.0.2.2 from CVM) - Document empty osImageHash in remote KMS attestation and the need for "0x" in osImages for receiver-side onboard checks - Recommend port forwarding over gateway for simpler test setup - Note that source_url must be CVM-reachable, not 127.0.0.1 - Update auth config templates with "0x" in osImages
kvinwang
added a commit
that referenced
this pull request
Mar 20, 2026
- Note 10 (empty osImageHash) is no longer applicable: new KMS uses unified PHALA_RATLS_ATTESTATION cert format, and old KMS source attestation gets os_image_hash filled from local KMS automatically - Remove "0x" entries from auth config templates - Update PR references and remove stale PR #538 dependency note
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dstack_client,app_attest,pad64,ensure_self_kms_allowed,ensure_kms_allowed) fromonboard_service.rsintoupgrade_authority.rsand reuse themensure_remote_kms_allowedwrapper that just delegated toensure_kms_allowedDstackGuestClient,AttestResponse,RawQuoteArgs,PrpcClient)Net result: -23 lines, no behavior change.
Follow-up to #573.
Test plan
cargo check -p dstack-kmspassescargo clippy -p dstack-kms --all-targets -- -D warningspasses