Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Add prek.toml with hooks for trailing whitespace, end-of-file, YAML/TOML/JSON validation, merge conflict detection, large file checks, cargo fmt, ruff lint+format, go vet, shellcheck, and conventional commit messages. Fix minor lint issues: add missing docstring in test_outputs.py, remove unused variable assignment in vmm-cli.py.
kvinwang
force-pushed
the
chore/add-prek-config
branch
from
b971582 to
43e96f1
Compare
The sdk/python config has strict docstring rules (D*) that don't apply to scripts outside sdk/python/. Add a minimal root-level ruff.toml with basic E/F/I rules only.
Remove root-level ruff.toml; pass lint rules via prek.toml args instead. Add proper docstrings to vmm-cli.py, ct_monitor.py, add-spdx-attribution.py, and app.py to comply with pydocstyle rules.
kvinwang
changed the title
Previous rebase lost newly added functions (discover_vmm_instances, load_config, etc). Restore master version and reapply: import sorting, docstrings, line length fixes, and unused variable removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prek.tomlwith pre-commit hooks: trailing whitespace, end-of-file fixer, YAML/TOML/JSON validation, merge conflict detection, large file check, cargo fmt, ruff (lint + format), go vet, shellcheck, and conventional commit messagesprek-check.ymlCI workflow that runs prek on changed files only (via--from-ref/--to-ref)test_outputs.py, unused variable invmm-cli.pyTest plan
prek run --all-filespasses locally (except shellcheck存量warnings)