fix: build libnvidia-container without network access#49
Open
fix: build libnvidia-container without network access#49
Conversation
- Add GOFLAGS=-mod=vendor to use the existing vendor directory in the source tree, eliminating Go module downloads during do_compile - Fix nvidia-modprobe version mismatch: recipe fetched 550.40.07 via SRC_URI but the source Makefile expected 550.54.14. The old do_compile[network]=1 masked this by re-downloading at build time - Apply nvidia-modprobe.patch in do_configure since we now skip the Makefile's curl-based download rule that previously applied it - Remove do_compile[network] = "1" Closes: #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOFLAGS=-mod=vendorto use the existing vendor directory in the source tree, eliminating Go module downloads duringdo_compileSRC_URIbut the source Makefile expected 550.54.14 (the olddo_compile[network]=1masked this by re-downloading at build time)nvidia-modprobe.patchindo_configuresince we now skip the Makefile's curl-based download ruledo_compile[network] = "1"Test plan
bitbake libnvidia-containerbuilds successfully without network indo_compilebuild.sh guestimage build passesPartially addresses #46 (libnvidia-container only; dstack-guest and dstack-sysbox are not feasible to fully offline, see comment on the issue)