[codex] use native-dom test environment#2
Draft
Dunqing wants to merge 1 commit into
Draft
Conversation
37be2b7 to
9b07570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
happy-domdev dependency with the publishedvitest-environment-native-dompackage.environment: "happy-dom"toenvironment: "native-dom".happy-domis no longer resolved or installed.Why
The native-dom environment now supports the app's DOM test surface without the local environment wrapper, and local benchmarks show it is faster than happy-dom for this suite.
Validation
vp install --frozen-lockfilevp checkvp test run- 25 files / 203 tests passedvp why happy-dom- no outputBenchmark Notes
Recent local wall-clock benchmark:
vp test run: native-dom mean 1.445svp test run --environment happy-dom: happy-dom mean 1.675sMemory was effectively neutral in local max-RSS sampling: native-dom averaged 541.8 MiB and happy-dom averaged 547.3 MiB.