Exclude default modules from searches on inara#854
Exclude default modules from searches on inara#854token419 wants to merge 1 commit intoEDCD:developfrom
Conversation
This builds a list of the default modules and then removes them from the current loadout, leading to more accurate searches on inara. An example where the current system can lead to less accurate results is, when searching a default ship, the hull armor is included, and many more stations may sell the ship than sell the hull armor for the ship, but the hull armor comes default when you buy the ship, even if the station does not sell the hull armor. The above scenario could happen for any particular E class module as well, where it comes on the ship, but the station itself may not sell it, so therefore would not be a candidate in the current search string.
|
Apologies for not using your PR, you obviously put work into it. With the upgrade to the new React, I've since built a system to do this exact same thing in the new codebase. Thank you for your effort. Please feel free to do further PR's, but to the https://github.com/Brighter-Applications/coriolis and https://github.com/Brighter-Applications/coriolis-data repos instead of the EDCD repo. This makes it much easier to implement users PR's. I need to add this information to the readme for the EDCD repo. |
|
Ah no worries here, I just wanted to upgrade the functionality. Sounds like you saw the need as well. The community will benefit so nothing is lost :) |
indeed, I actually opened an issue for it shortly after I took over as maintainer. You may not see it in live yet, as the cache on the live site is quite strong, but in alpha and beta sites, it's confirmed working and has been pushed to the live codebase. Thanks again for your efforts. |
|
Just noticed the update went live on the site it looks like, nice work! I noticed that when searching for a ship build now that the ship itself is not included in the search :p Just figured I'd pass it along hehe |
That's a very good point! I'll create an issue to track and add the ship back into the search. |
2 participants
This builds a list of the default modules and then removes them from the current loadout, leading to more accurate searches on inara.
An example where the current system can lead to less accurate results is, when searching a default ship, the hull armor is included, and many more stations may sell the ship than sell the hull armor for the ship, but the hull armor comes default when you buy the ship, even if the station does not sell the hull armor.
The above scenario could happen for any particular E class module as well, where it comes on the ship, but the station itself may not sell it, so therefore would not be a candidate in the current search string.