fix: sync eurac_pv_farm_detection udp description with the markdown docs#57
Closed
rahmandawibowo-vito wants to merge 2 commits intomainfrom
Closed
fix: sync eurac_pv_farm_detection udp description with the markdown docs#57rahmandawibowo-vito wants to merge 2 commits intomainfrom
rahmandawibowo-vito wants to merge 2 commits intomainfrom
Conversation
soxofaan
reviewed
Nov 8, 2024
HansVRP
requested changes
Nov 12, 2024
Contributor
HansVRP
left a comment
HansVRP
left a comment
There was a problem hiding this comment.
Minor changes, thank you for updating the documentation!
| Sources: | ||
| Photovoltaic farms (PV farms) mapping is essential for establishing valid policies regarding natural resources management and clean energy. As evidenced by the recent COP28 summit, where almost 120 global leaders pledged to triple the world’s renewable energy capacity before 2030, it is crucial to make these mapping efforts scalable and reproducible. Recently, there were efforts towards the global mapping of PV farms [1], but these were limited to fixed time periods of the analyzed satellite imagery and not openly reproducible. | ||
|
|
||
| To resolve this limitation we implemented the detection workflow for mapping solar farms using Sentinel-2 imagery in an openEO process [2]. |
| [2] Schramm, M, et al. The openEO API–Harmonising the Use of Earth Observation Cloud Services Using Virtual Data Cube Functionalities. Remote Sens. 2021, 13, 1125. https://doi.org/10.3390/rs13061125 | ||
|
|
||
| [3] https://github.com/clausmichele/openEO_photovoltaic/tree/main No newline at end of file | ||
| [3]: Alasawedah, M., Claus, M., Jacob, A., Griffiths, P., Dries, J., and Lippens, S.: Photovoltaic Farms Mapping using openEO Platform, EGU General Assembly 2024, Vienna, Austria, 14–19 Apr 2024, EGU24-16841, https://doi.org/10.5194/egusphere-egu24-16841, 2024. |
Contributor
There was a problem hiding this comment.
I would keep the reference to the original github repo
Contributor
|
this PR got quite out of sync with the repo (e.g. restructuring of folder layout) is it still worthwhile to keep it open, or can we close as wontfix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I try to sync the UDP description with the one from the markdown file.
The reason is because the description provided on the markdown here https://github.com/ESA-APEx/apex_algorithms/blob/main/algorithm_catalog/eurac_pv_farm_detection/eurac_pv_farm_detection_description.md seems to be more up-to-date than its UDP description (the UDP description only contain a single paragraph, whereas the markdown file contains performance characteristics & example with images).
I also rename the assets folder to be algorithm_catalog/eurac_pv_farm_detection_files/ to standardize with the other UDPs folder naming, and make it easier for the catalogue site to build the reference to the raw image URL.
Diff preview: https://www.diffchecker.com/ewFKwc4u/
Related PR: #44