Skip to content

Fix clang build: constexpr pi initialization #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
The9Cat merged 2 commits into from
Mar 14, 2026
Merged

Fix clang build: constexpr pi initialization #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e0233
Initial plan
Copilot Mar 14, 2026
9c0d024
Fix clang build: change constexpr to const for pi = std::acos(-1.0)
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/Test/testDeproject.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "cxxopts.H"

namespace {
constexpr double pi = std::acos(-1.0);
const double pi = std::acos(-1.0);
}

using namespace Deproject;
Expand Down
2 changes: 1 addition & 1 deletion utils/Test/testEmpDeproj.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ int main(int argc, char* argv[])
int Nr, Ngrid, NumR, Nint;

// Define pi in a portable way instead of relying on non-standard M_PI
constexpr double pi = std::acos(-1.0);
const double pi = std::acos(-1.0);

// Parse command-line options
//
Expand Down