Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Zarr loading logic by centralizing operations in ZarrLoaderLRU.ts and delegating store-specific tasks to icechunk-store.ts and zarrita-store.ts. It also introduces a comprehensive set of shared utilities in utils.ts for path handling, size summaries, and retry mechanisms. The review feedback identifies several high-priority improvements: parallelizing dimension fetching to improve performance, adding safety checks for JSON parsing of metadata, fixing dimension resolution for variables within sub-groups, and correcting the fallback logic for missing dimension arrays in the cache to respect the actual dimension shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #628 #627