Skip to content

fix icechunk dims#633

Closed
lazarusA wants to merge 6 commits intomainfrom
la/fix_dims
Closed

fix icechunk dims#633
lazarusA wants to merge 6 commits intomainfrom
la/fix_dims

Conversation

@lazarusA
Copy link
Copy Markdown
Member

fixes #628 #627

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Zarr loading logic by centralizing operations in ZarrLoaderLRU.ts and delegating store-specific tasks to icechunk-store.ts and zarrita-store.ts. It also introduces a comprehensive set of shared utilities in utils.ts for path handling, size summaries, and retry mechanisms. The review feedback identifies several high-priority improvements: parallelizing dimension fetching to improve performance, adding safety checks for JSON parsing of metadata, fixing dimension resolution for variables within sub-groups, and correcting the fallback logic for missing dimension arrays in the cache to respect the actual dimension shape.

Comment thread src/components/zarr/icechunk-store.ts
Comment thread src/components/zarr/zarrita-store.ts
Comment thread src/components/zarr/ZarrLoaderLRU.ts
@lazarusA lazarusA closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetZarrDims

1 participant