You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes the und_delta pragma, turning it on by default. Also fixes the stdlib to avoid emitting these new warnings.
I was a bit worried there might be false positives, but the worst I've seen is it emitting a warning for rewrite chains with multiple active goals when the unfold is useless in one of the goals. This was the case for the changes I made to RealSeries and BitEncoding. I think this is fair to keep around since we have the same behaviour for other rewrites when they fail on a single subgoal.
Do we want to merge this or #1014 first? The one that gets merged last will have to deal with the additional warnings from useless unfolds of auto unfolded operators.
What the argument against making this an error not a warning? The problem with warnings is that unless one is single stepping in Proof General or running in batch mode, they'll be missed. Just as rewrite foo is an error if it can't be applied, why not make unfolding that does nothing an error?
What the argument against making this an error not a warning? The problem with warnings is that unless one is single stepping in Proof General or running in batch mode, they'll be missed. Just as rewrite foo is an error if it can't be applied, why not make unfolding that does nothing an error?
"No breaking changes in the two weeks before a release if we can avoid it."
This gives us a nice bit of staging to detect breakage in external proofs without having to change them, so that the switch to making it an error is easier in the next release cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
und_deltapragma, turning it on by default. Also fixes the stdlib to avoid emitting these new warnings.I was a bit worried there might be false positives, but the worst I've seen is it emitting a warning for rewrite chains with multiple active goals when the unfold is useless in one of the goals. This was the case for the changes I made to
RealSeriesandBitEncoding. I think this is fair to keep around since we have the same behaviour for other rewrites when they fail on a single subgoal.Do we want to merge this or #1014 first? The one that gets merged last will have to deal with the additional warnings from useless unfolds of auto unfolded operators.