RFC: Add db:: accessor for LDB and LMT data#2285
Closed
mateofio wants to merge 2 commits intoEasyRPG:masterfrom
Closed
RFC: Add db:: accessor for LDB and LMT data#2285mateofio wants to merge 2 commits intoEasyRPG:masterfrom
mateofio wants to merge 2 commits intoEasyRPG:masterfrom
Conversation
5506151 to
50e098d
Compare
Member
|
Imo this looks fine. The Editor code is also already written in such a way that there is no global access anymore. What I would suggest here:
|
Member
|
Closing this due to lack of interest and progress. Please reopen when there are any updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: EasyRPG/liblcf#384
Fix: #2281
This is a new interface to access the lcf database and treemap from all Player code.
Essentially we will change from this:
To this
The reasons for changing this interface are:
lcf::Dataand all singletons from liblcf.db::db.hdoesn't bring in any lcf/rpg headers, only forward declarations.I'm posting this for review on the interface. Once everyone is on board with the design, I'll add commits to this porting Player code to use the new interface. Need to avoid rebase hell on this one.