Infinite: Update to new API spec, final touchups #5916

Jon-edge · 2026-01-22T04:49:57Z

More surprise API changes from Infinite, integrate to allow KYC form submission on Edge's side:
/customer endpoint changed personalInfo -> individualData
Properly pre-populate nationality
Add extended form input (DOB, SSN, etc) and supporting UI
Fix draft/pending KYC workflow (going back on incomplete web form KYC) to allow revisiting the KYC url.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

Tested on iOS device
Tested on Android device
Tested on small-screen device (iPod Touch)
Tested on large-screen device (tablet)

Note

Aligns ramp flows with Infinite’s latest API and improves KYC/banking UX with validation, prefills, and better pending handling.

Infinite API: Rename personalInfo→individualData, include phone, dateOfBirth, taxIdentificationNumber, nationality; add DRAFT KYC status
KYC workflow: Submit new fields, prefill nationality, handle incomplete statuses; pending scene can show "Complete KYC" button and re-check after webview
New RampKycFormScene: Adds phone, dateOfBirth (with date picker), and ssn fields with formatting/validation; improved field navigation and errors
Bank form: Accepts initialFirstName/LastName, sets default account nickname, reorganized sections; DevTestScene prepopulates from vault
UI components: FilledTextInput gains hideCharacterCount; new form field types (phone, date, ssn) with defaults
Region select: Auto-opens country modal; improved error handling
Vault/locales: Add getPersonalInfo and new strings/placeholders

^{Written by Cursor Bugbot for commit 3da81c8. This will update automatically on new commits. Configure here.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1212920259829433

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd06d7a4eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b987ef1bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/components/scenes/RampKycFormScene.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4c130cba9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

src/types/FormTypes.ts

swansontec

Found a few small things.

src/components/scenes/RampPendingScene.tsx

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

src/components/scenes/RampCreateScene/RampRegionSelect.tsx

src/components/scenes/DevTestScene.tsx

Pass onComplete/onClose directly to onPress, dropping the handler wrappers. Per PR comment: #5916 (comment)

Extract runOnce helper for concurrency logic in onComplete callback. Per PR comment: #5916 (comment)

Use explicit error type annotation in catch handlers. Change formData type from any to unknown. Per PR comments: - #5916 (comment) - #5916 (comment) - #5916 (comment)

Pass onComplete/onClose directly to onPress, dropping the handler wrappers. Per PR comment: #5916 (comment)

Extract runOnce helper for concurrency logic in onComplete callback. Per PR comment: #5916 (comment)

Use explicit error type annotation in catch handlers. Change formData type from any to unknown. Per PR comments: - #5916 (comment) - #5916 (comment) - #5916 (comment)

cursor · 2026-01-24T00:25:46Z

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

+              // Status changed but not yet active - navigate back and re-show
+              // pending scene with updated status. This ensures the UI reflects
+              // the new status and starts polling if appropriate (e.g. IN_REVIEW).
+              navigationFlow.goBack()


Extra goBack causes unexpected navigation from root screen

High Severity

The navigationFlow.goBack() call at line 331 is redundant and problematic. When openKycWebView completes, the navigation has already returned to the root screen (because rampPending was replaced by the webview via navigation.replace(), then the webview closed via goBack()). Calling goBack() again attempts to navigate back from root, which could unexpectedly exit the entire ramp flow or navigate to an unintended screen.

Is this extra goBack Cursor noticed a real concern?

Not valid, though it's true the code is a bit convoluted. Just added a comment

swansontec

This seems good, except that Cursor found one extra thing. Not sure if it's real or not.

swansontec · 2026-01-24T00:30:30Z

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

+              // Status changed but not yet active - navigate back and re-show
+              // pending scene with updated status. This ensures the UI reflects
+              // the new status and starts polling if appropriate (e.g. IN_REVIEW).
+              navigationFlow.goBack()


Is this extra goBack Cursor noticed a real concern?

`/customer` endpoint changed `personalInfo` -> `individualData`

Previously only gave the option to go back to the `RampSelectOptionScene` when the KYC was incomplete.

TODO: Replace the entire instructional scene with a country selection list instead of a modal in the event there is no region selected. Excess instruction manuals and modals should be avoided and this is a place it can easily be avoided.

"Account Name" confusing. Renamed to "Account Nickname"

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-24T01:10:15Z

src/plugins/ramps/infinite/workflows/kycWorkflow.ts

+    const isKycIncomplete =
+      initialStatus === 'PENDING' ||
+      initialStatus === 'NEED_ACTIONS' ||
+      initialStatus === 'DRAFT'


Status change from IN_REVIEW to incomplete causes error

Low Severity

The isKycIncomplete flag is computed once based on initialStatus and determines whether to show the "Complete KYC" button and whether to reject on non-approved statuses. If a user starts with IN_REVIEW status (where isKycIncomplete is false) and the backend later requests additional information (changing to NEED_ACTIONS), the workflow rejects with an error instead of allowing the user to tap "Complete KYC". The status check at lines 303-308 only keeps the flow alive for incomplete statuses if the initial status was incomplete.

Additional Locations (1)

src/plugins/ramps/infinite/workflows/kycWorkflow.ts#L299-L308

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from fb5284e to eb5b925 Compare January 22, 2026 06:18

Jon-edge marked this pull request as draft January 22, 2026 07:21

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch 2 times, most recently from 8696a2d to fd06d7a Compare January 22, 2026 20:13

Jon-edge marked this pull request as ready for review January 22, 2026 20:44

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

src/plugins/ramps/infinite/workflows/kycWorkflow.ts Outdated Show resolved Hide resolved

Jon-edge changed the title ~~Update to new API spec~~ Update to new API spec, Final changes Jan 22, 2026

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from fd06d7a to f9c6477 Compare January 22, 2026 20:58

This comment was marked as outdated.

Sign in to view

Jon-edge marked this pull request as draft January 22, 2026 21:33

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from f9c6477 to 0b987ef Compare January 22, 2026 21:37

Jon-edge marked this pull request as ready for review January 22, 2026 22:10

This comment was marked as outdated.

Sign in to view

Jon-edge changed the title ~~Update to new API spec, Final changes~~ Update to new API spec, final touchups Jan 22, 2026

Jon-edge changed the title ~~Update to new API spec, final touchups~~ Infinite: Update to new API spec, final touchups Jan 22, 2026

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

src/components/scenes/RampKycFormScene.tsx Outdated Show resolved Hide resolved

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from 0b987ef to 83e4a8e Compare January 22, 2026 22:47

This comment was marked as outdated.

Sign in to view

Jon-edge marked this pull request as draft January 22, 2026 23:17

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch 5 times, most recently from aeb7411 to c4c130c Compare January 23, 2026 00:16

Jon-edge marked this pull request as ready for review January 23, 2026 00:47

chatgpt-codex-connector bot reviewed Jan 23, 2026

View reviewed changes

src/plugins/ramps/infinite/workflows/kycWorkflow.ts Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from c4c130c to 2c0b096 Compare January 23, 2026 01:06

cursor bot reviewed Jan 23, 2026

View reviewed changes

src/types/FormTypes.ts Show resolved Hide resolved

swansontec requested changes Jan 23, 2026

View reviewed changes

Jon-edge added a commit that referenced this pull request Jan 23, 2026

fixup! Update CTA to finish incomplete KYCs

35c5de2

Pass onComplete/onClose directly to onPress, dropping the handler wrappers. Per PR comment: #5916 (comment)

Jon-edge added a commit that referenced this pull request Jan 23, 2026

fixup! Force country selection

e54c7cf

Extract runOnce helper for concurrency logic in onComplete callback. Per PR comment: #5916 (comment)

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from f77cd7b to a57c037 Compare January 23, 2026 23:46

Jon-edge added a commit that referenced this pull request Jan 23, 2026

fixup! Update CTA to finish incomplete KYCs

fb989f5

Pass onComplete/onClose directly to onPress, dropping the handler wrappers. Per PR comment: #5916 (comment)

Jon-edge added a commit that referenced this pull request Jan 23, 2026

fixup! Force country selection

c568b27

Extract runOnce helper for concurrency logic in onComplete callback. Per PR comment: #5916 (comment)

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from a57c037 to 1f9504b Compare January 23, 2026 23:46

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch 2 times, most recently from ccf3d09 to fd57cc9 Compare January 24, 2026 00:14

cursor bot reviewed Jan 24, 2026

View reviewed changes

swansontec approved these changes Jan 24, 2026

View reviewed changes

Jon-edge added 3 commits January 23, 2026 16:50

Update to new API spec

c07045a

`/customer` endpoint changed `personalInfo` -> `individualData`

Add missing KYC form fields

4274ac0

Update CTA to finish incomplete KYCs

c2a8fb8

Previously only gave the option to go back to the `RampSelectOptionScene` when the KYC was incomplete.

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from fd57cc9 to cb1bc05 Compare January 24, 2026 00:50

Jon-edge added 3 commits January 23, 2026 16:58

Force country selection

9812a40

TODO: Replace the entire instructional scene with a country selection list instead of a modal in the event there is no region selected. Excess instruction manuals and modals should be avoided and this is a place it can easily be avoided.

Update bank details copy/layout

f9e5fb1

"Account Name" confusing. Renamed to "Account Nickname"

Prepopulate first/last name & nickname in RampBankFormScene

3da81c8

Jon-edge force-pushed the jon/fix/hopefully-final-infinite-api branch from cb1bc05 to 3da81c8 Compare January 24, 2026 00:58

Jon-edge enabled auto-merge January 24, 2026 00:58

cursor bot reviewed Jan 24, 2026

View reviewed changes

Jon-edge merged commit 430b62b into develop Jan 24, 2026
4 checks passed

Jon-edge deleted the jon/fix/hopefully-final-infinite-api branch January 24, 2026 01:18

Infinite: Update to new API spec, final touchups #5916

Infinite: Update to new API spec, final touchups #5916

Conversation

Jon-edge commented Jan 22, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Requirements

Uh oh!

This comment was marked as outdated.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

swansontec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Jan 24, 2026

Choose a reason for hiding this comment

Extra goBack causes unexpected navigation from root screen

Uh oh!

swansontec Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Jon-edge Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

swansontec left a comment

Choose a reason for hiding this comment

Uh oh!

swansontec Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 24, 2026

Choose a reason for hiding this comment

Status change from IN_REVIEW to incomplete causes error

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jon-edge commented Jan 22, 2026 •

edited by cursor bot

Loading