docs(@effect/vitest): fix return type in fails example#6163
Open
aymenhmaidiwastaken wants to merge 1 commit intoEffect-TS:mainfrom
Open
docs(@effect/vitest): fix return type in fails example#6163aymenhmaidiwastaken wants to merge 1 commit intoEffect-TS:mainfrom
aymenhmaidiwastaken wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
The divide function in the 'Expecting Tests to Fail' example was annotated as returning 'number' but actually returns Effect.Effect<number, string>. Ref Effect-TS#5934
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dividefunction's return type annotation in the "Expecting Tests to Fail" section of the@effect/vitestREADMEnumberbut actually returnsEffect.Effect<number, string>The
it.effect.failsmethod itself was already added in #3973, so this just fixes the remaining type error in the example code.Ref #5934