-
Notifications
You must be signed in to change notification settings - Fork 399
rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses #1522
Conversation
|
Tested ACK a4eeed9 |
a4eeed9 to
f2bd052
Compare
|
NACK a4eeed9, have read the diff |
jsarenik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2shwsh seems very non-standard and I do not know what is meant by that. Did you mean following?
sh(wpkh), Nested Segwit, P2SH-segwit
(all above are the same thing, how people call it, better do not add another)
|
It's wrapped segwit. |
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of the tweaked address. "address" has been removed from the result and replaced with "p2wsh" and "p2shwsh".
f2bd052 to
5d64e89
Compare
|
Tested ACK 5d64e89 |
Thanks for the link. One can not find it in Bitcoin Core nor in Elements Core doc and there's nothing like term "wrapped segwit" in the sources making the words ungreppable in the repo. I just think that calling the same thing in multiple different ways may be confusing for the newcomers. Update: there's a mention on a very long line here: elements/doc/external-signer.md Line 91 in 6d29a59
And
And although not self-standing
So I've just never seen it in Bitcoin context yet. |
Adds yet another way to name a Nested Segwit. See ElementsProject/elements#1522
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of
the tweaked address.
"address" has been removed from the tweakfedpegscript RPC result and replaced with "p2wsh" and
"p2shwsh" addresses.