tests: mock all currencyrate endpoints#9182
Open
daywalker90 wants to merge 1 commit into
Open
Conversation
specifically coingecko was constantly hitting API rate limits causing our tests to fail so lets mock all endpoints with a snapshot of real responses If the actual API's change, break, or vanish we have to notice it in a different way Changelog-None
daywalker90
force-pushed
the
currencyrate-mock-liveapis
branch
from
b38af23 to
ee1dae8
Compare
madelinevibes
added
the
Status::Ready for Review
Collaborator
|
I believe this level of mocking would fit a Unit Test better than an Integration Test. This error helps us tell, like you said:
Wouldn't it be better to catch and propagate the error back to the test? This way we would know it's a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specifically coingecko was constantly hitting API rate limits causing our tests to fail so lets mock all endpoints with a snapshot of real responses
If the actual API's change, break, or vanish we have to notice it in a different way