Add system tests (for events calendar view)#1314
Open
fbacall wants to merge 5 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/ElixirTeSS/TeSS/sessions/427a7bae-9e9f-4ae8-8977-17b925fec24c Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ElixirTeSS/TeSS/sessions/2a3b05a5-ac64-45dd-90f2-21a62813e5bb Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>
and rename it
b49f4e3 to
f96cd49
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Rails system test infrastructure (Capybara/Selenium) and a system test to validate that the Events “Calendar” tab loads the calendar via AJAX and renders an event, intended to guard against regressions like the jQuery/CSP issue fixed in #1309.
Changes:
- Add Capybara + Selenium WebDriver and a base
ApplicationSystemTestCasefor headless Chrome system tests. - Add a system test covering the Events calendar tab AJAX load/render path.
- Update CI workflow to run system tests.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/test_helper.rb | Adjust VCR config to ignore localhost requests. |
| test/application_system_test_case.rb | Introduces shared system test base class using headless Chrome (Selenium). |
| test/system/events_calendar_system_test.rb | New system test asserting calendar tab loads and renders an event. |
| Gemfile | Adds capybara and selenium-webdriver to the test group. |
| Gemfile.lock | Locks new test dependencies (Capybara, Selenium, transitive deps). |
| .github/workflows/test.yml | Renames workflow and adds a step to run rails test:system. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| class EventsCalendarSystemTest < ApplicationSystemTestCase | ||
| test 'calendar tab loads and renders events with javascript' do | ||
| freeze_time(Time.utc(2026, 5, 20, 12, 0, 0)) do | ||
| Event.create!( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
Catches the issue that was resolved by #1309
Can be used to test other JS features.
Checklist