Warn and ignore variadic expansions that can't be handled properly#708
Open
taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
Open
Warn and ignore variadic expansions that can't be handled properly#708taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
Conversation
taminomara
force-pushed
the
spurious-variadics
branch
from
f020644 to
c3e7444
Compare
CppCXY
reviewed
Aug 12, 2025
crates/emmylua_code_analysis/src/compilation/test/variadic_test.rs
Outdated
Show resolved
Hide resolved
This PR checks for situation where variadic type expansion operator (`T...`) is used in an unexpected place, and can't be handled properly. Users will get a warning about such situations, and the operator will be ignored. This prevents unexpected variadic types such as: ```lua local x --- @type integer... local x1, x2 = x -- ^ EmmyLua thinks `x` is a result of a variadic expansion, -- ^^ ^^ so it infers both `x1` and `x2` as integers. ``` Fix EmmyLuaLs#701
taminomara
force-pushed
the
spurious-variadics
branch
from
c3e7444 to
c8a5bd3
Compare
Contributor
Author
|
Ping? |
Member
|
code conflicts |
Contributor
Author
|
Sorry, I was busy with other tasks, I'll take a look at it tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks for situation where variadic type expansion operator (
T...) is used in an unexpected place, and can't be handled properly. Users will get a warning about such situations, and the operator will be ignored.This prevents unexpected variadic types such as:
Fix #701