Prevent double variadic wrapping when inferring ...#709
Open
taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
Open
Prevent double variadic wrapping when inferring ...#709taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
...#709taminomara wants to merge 1 commit intoEmmyLuaLs:mainfrom
Conversation
This prevents situation when `...` is annotated as variadic (`@param ... T...`), and its type is inferred as `(T...)...`
CppCXY
reviewed
Aug 12, 2025
| "#, | ||
| ); | ||
| let a_ty = get_type_of_first_local_assign(&mut ws, file_id); | ||
| assert_eq!(&ws.humanize_type(a_ty), "T[]"); |
Contributor
Author
There was a problem hiding this comment.
I know, but I'm not sure how to compare types properly without hardcoding GenericTplIds?
Contributor
Author
|
Ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents situation when
...is annotated as variadic (@param ... T...), and its type is inferred as(T...)...