Add pylint

[furtib]

Why:
To enforce coding standards

What:

• Added requirements.txt
• Added a CI workflow for pylint
• Disabled checks:
  • fixme - We use this to indicate a test being disabled
  • in legacy - code-duplication: This test is mostly untouchable; code duplication is unavoidable
• Disabled files:
  • template - Errors in this file are to be fixed by the copier. (e.g. self.assertTrue(True) or setUp methods are considered issues by pylint, while they are just unfinished)

Note:

• Developers can easily obtain PyLint using requirements.txt.

Addresses:
Fixes: #153

[nettle]

Great initiative! Thanks @furtib!
I'm just wondering why we have only 2 findings? :)
I ran pylint some time before and there were much more findings.
I'll double-check

[nettle]

Great initiative! Thanks @furtib! I'm just wondering why we have only 2 findings? :) I ran pylint some time before and there were much more findings. I'll double-check

Oh, sorry, there are more!
I just havent noticed :)

[Szelethus]

I suppose we should fix the issues pylint found, and then merge.

[Szelethus]

Can we add this to test/test.sh?

[Szelethus]

Ugh, I think we could just merge this if we don't open the makefile can of worms. For instance, this is not I set up my environment.

I don't recall, what was the argument against adding this to test.sh?

[furtib]

Okay, I will remove the Makefile and try to make running the linters easier locally in a follow-up patch.

The argument against changing test.sh is that that specific file is used by a testing CI, which does not have pylint installed.

[Szelethus]

Send it.