Open
Conversation
…` and fix name mapping handling.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the UserManager to ensure correct handling of user name updates. The updateNameIfChanged method now returns an updated User object (a new instance if the name changed) and correctly manages the usersByName map by removing old name mappings, which improves consistency across cached and persisted user data. However, the current implementation of updateNameIfChanged introduces a critical race condition that can lead to data corruption if multiple threads concurrently update the same user's name. It is recommended to implement a synchronized block or a per-user locking mechanism to ensure thread safety.
eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already tested on production.