added mysql trace backend #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishagg
requested changes
Mar 1, 2019
.../expedia/www/haystack/trace/storage/backends/mysql/integration/BaseIntegrationTestSpec.scala
Outdated
Show resolved
Hide resolved
ashishagg
requested changes
Mar 1, 2019
ashishagg
requested changes
Mar 1, 2019
ashishagg
requested changes
Mar 1, 2019
| @@ -0,0 +1,21 @@ | |||
| # Storage Backend - Mysql | |||
|
|
|||
| Grpc service which can read a write spans to a mysql cluster | |||
There was a problem hiding this comment.
It might be useful for newbies to mention that mysql still needs elasticsearch for indexing. When I first looked at your branch, I quickly looked for indexing..
Member
Author
|
makes sense. Will add that in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mysql trace backend to support storing raw spans in mysql for haystack tracing.
closes ExpediaDotCom/haystack#644