Skip to content

Add hasFailedOnfido to acceptWalletTerms failureData #85579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
allgandalf wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add hasFailedOnfido to acceptWalletTerms failureData #85579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/actions/Wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ function acceptWalletTerms(parameters: AcceptWalletTermsParams) {
value: {
isPendingOnfidoResult: null,
shouldShowFailedKYC: true,
hasFailedOnfido: true,
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate hasFailedOnfido update to KYC-specific failures

failureData is applied on every non-200 API response (see applyHTTPSOnyxUpdates in src/libs/actions/OnyxUpdates.ts, which runs request.failureData whenever response.jsonCode !== 200), so this unconditional hasFailedOnfido: true merge will also run for transient/non-KYC failures of ACCEPT_WALLET_TERMS (e.g., server errors). In those cases the wallet gets marked as failed and the UI redirects/hides activation based on hasFailedOnfido, which blocks normal retry behavior for users who did not actually fail Onfido.

Useful? React with 👍 / 👎.

},
},
{
Expand Down
Loading