Align report details custom columns#93530
Draft
zhenzheng1-ctrl wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the Report Details custom column list with the expense Search custom columns for transaction-level fields that can vary within a report.
This adds the missing Report Details options for:
It also adds a shared availability config so future expense custom columns require an explicit Search vs Report Details decision, and updates
getColumnsToShow()so the newly selectable data-driven columns are not filtered out when a transaction has the relevant data.Issue: #93522
Tests
npx prettier --check src/CONST/index.ts src/libs/SearchUIUtils.ts tests/unit/Search/SearchUIUtilsTest.tsgit diff --check HEAD~1..HEADI also attempted a targeted Jest run:
npx jest tests/unit/Search/SearchUIUtilsTest.ts --runInBand -t "selected report detail columns|expense search and report details columns aligned"The Jest suite did not start in this local Windows sparse checkout because module resolution failed before test execution:
Cannot find module '@react-navigation/native' from 'src/libs/ReportUtils.ts'