Fix failing build after migration off of imgur hosting#31
Open
lorow wants to merge 2 commits into
Open
Conversation
lorow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that
doesn't really work with relative paths to images so I went ahead and replaced them all withImageCard- that needed a small change - I removed the margin bottom from its style.With this, some pages needed their spacing adjusted, I went ahead and verified if it more or less looks correct manually, side by side, having open the production version and the dev version and just compared what differed.
I've also ran
pnpm build && pnpm serveto make sure it does build - it did