Skip to content

Add 'upload_map' and 'upload_mod' to python client scope#290

Open
Gatsik wants to merge 1 commit intoFAForever:developfrom
Gatsik:patch-1
Open

Add 'upload_map' and 'upload_mod' to python client scope#290
Gatsik wants to merge 1 commit intoFAForever:developfrom
Gatsik:patch-1

Conversation

@Gatsik
Copy link

@Gatsik Gatsik commented Mar 19, 2026

Summary by CodeRabbit

  • New Features
    • FAF Classic Client now has permissions to upload maps and mods through OAuth authentication.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7bcdd1bb-dce9-4439-8274-c0537c9444a3

📥 Commits

Reviewing files that changed from the base of the PR and between 3e61171 and 10d7372.

📒 Files selected for processing (1)
  • apps/ory-hydra/values.yaml

📝 Walkthrough

Walkthrough

Updated the OAuth scope configuration for the "FAF Classic Client (Python)" in Ory Hydra by appending upload_map and upload_mod permissions to the existing scope list in the Helm values configuration file.

Changes

Cohort / File(s) Summary
OAuth Scope Configuration
apps/ory-hydra/values.yaml
Added upload_map and upload_mod scopes to the FAF Classic Client (Python) OAuth scope list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A scope update, modest and fine,
Maps and mods now align,
Fresh permissions take flight,
Through OAuth's gateway, shining bright,
Access granted, all is right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding 'upload_map' and 'upload_mod' scopes to the Python client configuration in the Hydra OAuth values file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant