Config: Finish wiring up Regex app overrides #5388
Conversation
neobrain
left a comment
neobrain
left a comment
There was a problem hiding this comment.
Getting there. Could you also squash the commits by author? There's no need for this change set to be broken into 13 patches, 2 should suffice.
I'm guessing this is done now? Not sure what PR this was intended to reference since 121 probably wasn't it. |
Oop, meant to be the PR number. |
Well, yes, but which one? Can you edit the description please? |
Squashed. |
neobrain
left a comment
neobrain
left a comment
There was a problem hiding this comment.
Last round, good to merge afterwards. (Though note we're back to 6 commits now...)
Add support for question mark and plus mark in regex, supply testing for star Added more characters to the regex alphabets, add more test case Added support for regex matching of configs, awaiting reviews Rename variable to CamelCase Addresses PR reviews Remove unnecessary features and test cases Rewrite to naive regex with dp Addresses PR reviews Build fixes Code Review
This wasn't quite wired up exactly how we wanted it. It was previously
matching against the opaque file config handle, which can be anything.
Instead compare it to the appname that now gets passed over to it for
matching.
This allows us to do the following:
```
{
"Config": {
"ProfileStats": "1",
"X87ReducedPrecision": "1",
"TSOEnabled": "1",
"VectorTSOEnabled": "0",
"MemcpySetTSOEnabled": "0",
"HalfBarrierTSOEnabled":"1",
"MaxInst": "500",
"Multiblock": "1"
},
"AppOverrides" : {
"setup*" : {
"Comment": [
"292030 - The Witcher 3: Wild Hunt"
],
"X87ReducedPrecision": "0"
}
}
}
```
Based on FEX-Emu#121 which needs to get merged first.
Code Review
Code Review: Class deletion
That's okay, commits are free. |
3 participants
This wasn't quite wired up exactly how we wanted it. It was previously
matching against the opaque file config handle, which can be anything.
Instead compare it to the appname that now gets passed over to it for
matching.
This allows us to do the following:
Based on #5386 which needs to get merged first.